Closed Bug 845161 Opened 7 years ago Closed 3 years ago

re-enable OOP for desktop builds

Categories

(Firefox OS Graveyard :: General, defect)

x86_64
All
defect
Not set

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: jduell.mcbugs, Unassigned)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch flip the pref (obsolete) — Splinter Review
Desktop B2G is fairly useless for debugging platform issues w/o OOP.  I apply this patch every time I debug anything.  It seems to work--do we know of any issues stopping us from making OOP the default?
Attachment #718210 - Flags: review?(jones.chris.g)
Comment on attachment 718210 [details] [diff] [review]
flip the pref

Did you test this on win32, mac, and linux-gtk?

I know where you're coming from, but OOP is just not well supported there.  If you'd like to get this in, we should have QA do a run on builds with the patch.
Attachment #718210 - Flags: review?(jones.chris.g)
We need this to make it easier for developers to fix tests they break.  If the barrier to fixing is too high, developers can and will just disable tests and land if they feel they've wasted too much time on them.  This causes regressions in the code previously tested.  This in turn puts more burden on the maintainers of that code.

So it's more efficient for everyone to have as many tests runnable everywhere as possible.
Blocks: b2g-testing
With this patch I have b2g-desktop running with OOP apps. There a couple of graphics issues though:
- some colors are wrong (eg. blue checkboxes are orange)
- we don't repaint when scrolling in the browser app.
Attachment #718210 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.