Tune ThebesLayer -> ColorLayer optimization to be more aggressive when buffer reallocation needs to happen anyway

NEW
Unassigned

Status

()

6 years ago
6 years ago

People

(Reporter: roc, Unassigned)

Tracking

18 Branch
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

See https://bugzilla.mozilla.org/show_bug.cgi?id=842215#c10

Currently we avoid switching from a ThebesLayer to a ColorLayer if buffers for the ThebesLayer have already been allocated, because otherwise we can get into bad buffer churn when content toggles in and out of the single-color state.

cjones points out that if we're going to reallocate buffers for the ThebesLayer anyway, and it's a single color, we might as well go to a ColorLayer. This apparently would be helpful for the B2G settings app.
Does this depend on the layers refactoring? It may depend on knowing when exactly buffer reallocations are going to happen inside the layers backend.
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #1)
> Does this depend on the layers refactoring? It may depend on knowing when
> exactly buffer reallocations are going to happen inside the layers backend.

I don't think it should. We have not touched FrameLayerBuilder and I hope we have not changed the frequency or manner of buffer allocations. But if this will require any kind of feedback from layers about when or how often buffers get allocated then it will be seriously affected.
We don't reallocate ThebesLayer buffers on every visible-region size change (right?) so I think this does depend on getting information from the layers implementation.
You need to log in before you can comment on or make changes to this bug.