84519 - after doing history.go(+tooFar), must press back button many times to go back

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Open a new browser window at your homepage.
2. Click a link.
3. javascript:history.go(5)
4. Try to go back to your homepage using the back button.

Results: 
- Must hit back 6 times to get back to the homepage.  
- The drop-down under the back button doesn't work.
- Lots of errors in the javascript console.

Expected: hitting back once goes back to the homepage.

Comment 1

[Jesse Ruderman]

See also bug 84527, history.go(-tooFar) disables session history.  Upgrading
this bug to major because if you use a very large positive number, the result is
basically the same as in bug 84527.

Comment 2

[Tom Mraz]

Not platform specific.

Comment 3

[Blake Ross]

Missed the 0.9.3 train.

Comment 4

[Radha on family leave (not reading bugmail)]

*** Bug 84527 has been marked as a duplicate of this bug. ***

Comment 5

[Radha on family leave (not reading bugmail)]

I think that for consistency and simplicity sake, the browser should do nothing
if the index that is provided by history.go() is unreachable, instead of trying
to go back or forward however far it can go. 

Comment 6

[Radha on family leave (not reading bugmail)]

Attachment: patch

Comment 7

[rpotts (gone)]

looks good.  r/sr=rpotts

Comment 8

[Asa Dotzler [:asa]]

a=asa on behalf of drivers pending r=

Comment 9

[Adam Lock]

r=adamlock

Comment 10

[Radha on family leave (not reading bugmail)]

Fix checked in to trunk.

Comment 11

[Tom Mraz]

Verified Linux 2001090608.