845227 - Remove various app folders like dogfood_apps, showcase_apps when the app customization is ready

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

When the app customization in Bug 838098 is ready, whether we could remove all  the apps under test_apps/ showcase_apps/ and dogfood_apps/, etc. and rely on the app customization entirely.

This might affect the build process of our partners, so I file this bug to gather your opinions on this.

Thanks.

Comment 1

[John Ford [:jhford] CET/CEST Berlin Time]

Did this happen?  Can we remove them?

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I will send a mail to dev-gaia to get a confirmation about if this can be executed now.
Thanks.

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Rudy Lu [:rudyl] from comment #2)
> I will send a mail to dev-gaia to get a confirmation about if this can be
> executed now.
> Thanks.

What was the outcome?

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I have not followed this topic for a while and it seems we have some major changes in build system right now.

May need Yuren and other build script experts to comment on this.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I sent an email to dev-gaia to discuss this.

https://groups.google.com/forum/#!topic/mozilla.dev.gaia/cWhG4MaU65I

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: github PR: https://github.com/mozilla-b2g/gaia/pull/18404

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

try server:
https://tbpl.mozilla.org/?tree=Try&rev=647ab9dba86a

travis:
https://travis-ci.org/mozilla-b2g/gaia/builds/23181686

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8408013 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/18404

Tim, could you review this pr? thanks!


BTW, I will send an email to dev-gaia to remind this change before landing.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8408013 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/18404

This is good but please ask dev-gaia before landing.

Just, FYI, git should be able to merge commit before this file-moving commit with 'recursive' strategy so we shouldn't be creating a lot of overhead here.

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I pushed to try server again since I got a lot of error, I suspect is cause by I updating gecko source code.

https://tbpl.mozilla.org/?tree=Try&rev=508c004fb719

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged.

https://github.com/mozilla-b2g/gaia/commit/ac3eba60d22e1cceeaefdc3f175d698506e9c990

Comment 12

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

try server after landing.

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=c45755d9b2c3

Comment 13

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Why is apps/*/shared being added to .gitignore? For some reason I had a apps/system/shared that needed to be deleted (no idea where it came from in the first place), but this patch means git clean -df no longer worked, so I had issues with gaia breaking due to finding old files.

Comment 14

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

it was a mistake, I filed a follow-up bug for it on bug 1009397