Closed Bug 845227 Opened 7 years ago Closed 6 years ago

Remove various app folders like dogfood_apps, showcase_apps when the app customization is ready

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Other
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S6 (25apr)

People

(Reporter: rudyl, Assigned: yurenju)

References

Details

Attachments

(1 file)

When the app customization in Bug 838098 is ready, whether we could remove all  the apps under test_apps/ showcase_apps/ and dogfood_apps/, etc. and rely on the app customization entirely.

This might affect the build process of our partners, so I file this bug to gather your opinions on this.

Thanks.
Did this happen?  Can we remove them?
Flags: needinfo?(rlu)
I will send a mail to dev-gaia to get a confirmation about if this can be executed now.
Thanks.
Flags: needinfo?(rlu)
(In reply to Rudy Lu [:rudyl] from comment #2)
> I will send a mail to dev-gaia to get a confirmation about if this can be
> executed now.
> Thanks.

What was the outcome?
Flags: needinfo?(rlu)
I have not followed this topic for a while and it seems we have some major changes in build system right now.

May need Yuren and other build script experts to comment on this.
Flags: needinfo?(yurenju.mozilla)
Flags: needinfo?(rlu)
I sent an email to dev-gaia to discuss this.

https://groups.google.com/forum/#!topic/mozilla.dev.gaia/cWhG4MaU65I
Assignee: nobody → yurenju.mozilla
Flags: needinfo?(yurenju.mozilla)
Comment on attachment 8408013 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/18404

Tim, could you review this pr? thanks!


BTW, I will send an email to dev-gaia to remind this change before landing.
Attachment #8408013 - Flags: review?(timdream)
Comment on attachment 8408013 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/18404

This is good but please ask dev-gaia before landing.

Just, FYI, git should be able to merge commit before this file-moving commit with 'recursive' strategy so we shouldn't be creating a lot of overhead here.
Attachment #8408013 - Flags: review?(timdream) → review+
I pushed to try server again since I got a lot of error, I suspect is cause by I updating gecko source code.

https://tbpl.mozilla.org/?tree=Try&rev=508c004fb719
merged.

https://github.com/mozilla-b2g/gaia/commit/ac3eba60d22e1cceeaefdc3f175d698506e9c990
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: GonkIntegration → Gaia::Build
Target Milestone: --- → 1.4 S6 (25apr)
Why is apps/*/shared being added to .gitignore? For some reason I had a apps/system/shared that needed to be deleted (no idea where it came from in the first place), but this patch means git clean -df no longer worked, so I had issues with gaia breaking due to finding old files.
it was a mistake, I filed a follow-up bug for it on bug 1009397
You need to log in before you can comment on or make changes to this bug.