845306 - Use 2x images for menu arrows

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Frank Yan (:fryn)]

Attachment: patch v1

Use 2x images for the menu arrows (the rightward-pointing arrows that indicate the item is a menu) and the arrows in <autorepeatbutton/> elements.

The odd thing is that OS X is using a 17px-wide arrow image, whereas our non-HiDPI version is 8px wide, which means that we'll need to do something like the following for HiDPI mode:
width: 8.5px;
margin-right: -.5px;

I created a 2x version of menu-arrow.png using Reuben's images in bug 795665, but they don't perfectly match OS X's.

Here's a preliminary patch for this. It looks a lot better in HiDPI mode than the incorrectly colored, fuzzy 1x images we have now, but it's not perfect.

Comment 1

[Reuben Morais [:reuben]]

Attachment: menu-arrow.png

Hey Frank, I think this is the correct image. I thought the other one was the menu arrow image because it also had a grey version, supposedly for disabled menus. This one looks more like the OS X menu arrow image, but I don't see disabled/selected states in the OS X files.

Comment 2

[Frank Yan (:fryn)]

(In reply to Reuben Morais [:reuben] from comment #1)
> Hey Frank, I think this is the correct image. I thought the other one was
> the menu arrow image because it also had a grey version, supposedly for
> disabled menus. This one looks more like the OS X menu arrow image, but I
> don't see disabled/selected states in the OS X files.

Interesting. Nice find. That does look more like it. Its large size seems to explain the anti-aliasing that hints of down-scaling in the native menu arrows.

I'm not sure what to do with this, but Stephen hopefully knows.
This is somewhat low priority compared to Stephen's multiple high-priority projects, so I removed the feedback flag for now, since it's not a trivial fix.

Comment 3

[Stephen Horlander [:shorlander]]

The small arrows are 9px wide, the larger arrows are 18 they just have 1 row of transparent pixels.

Comment 4

[Stephen Horlander [:shorlander]]

Attachment: Menu Arrow @2x

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: Menu Arrow

Had to adjust the size. Now 27 x 10 was 24 x 10

Comment 6

[Frank Yan (:fryn)]

Attachment: patch v2

Try run was all green, including reftests:
https://tbpl.mozilla.org/?tree=Try&rev=7639bf90e016

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5e9be4f5489d