84531 - DNS: cache eviction count not always decremented

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[gordon]

There is a case in nsDNSService::FindOrCreateLookup() where a lookup is removed 
from the eviction queue, but the count for the queue is not decremented.  This 
results in the actually max queue length shortening to zero over time.

Comment 1

[gordon]

Attachment: Patch to fix eviction count.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

a=dbaron for trunk checkin (on behalf of drivers).
(http://bugzilla.mozilla.org/show_activity.cgi?id=84531 shows it has r= and sr=)

Comment 3

[gordon]

Patch checked in. Marking FIXED.

Comment 4

[Sivakiran Tummala]

 not consistant...the count is very high compared to the number of entries

Comment 5

[gordon]

What platform did you see this on?  What build?

Comment 6

[Christopher Hoess (gone)]

milestone->0.9.7. cc'ing stummala, who never replied.

Comment 7

[Sivakiran Tummala]

I am not the QA contact for this bug, i reopened this bug not even on CC 
list. Thanks Christopher for CCing me. I might have used the 08-01 build. I will 
reproduce this bug and give the build ID

Comment 8

[gordon]

After testing this a bit and examining the queue and queue count, I don't see any 
problem.  Sivakiran, if you can explain how you determined the queue count was 
incorrect, and can reproduce the problem we can reopen this.  Re-marking FIXED.

Comment 9

[benc]

VERIFIED:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsDnsService.cpp&branch=&root=/cvsroot&subdir=mozilla/netwerk/dns/src&command=DIFF_FRAMESET&rev1=1.83&rev2=1.84