845312 - Modification in Spanish keyboard to allow writing in Catalan

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Toni Hermoso Pulido]

Attachment: Addition of middot for Catalan in Spanish keyboard layout

Below we propose a patch for introducing middot:
http://en.wikipedia.org/wiki/Middot

A convenient addition, since many users may use both Spanish and Catalan.

Proposal is similar to current iOS6 approach.
As partial option in . (1 char ·) = http://www.l·l.cat/static/comunicat01/iPhone_iOS6_ditAlPuntVolat.jpg
As full option in l (3 chars l·l) http://www.l·l.cat/static/comunicat01/iPhone_iOS6_ditAelaGeminada.jpg

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yes, I have seen the alternative chars as you said on iOS 6, but in a separate keyboard layout as "Catalan".

[+cc Casey and Rafael]
Do we need to separate this into another keyboard layout or just add these alternative chars into Spanish keyboard?

Comment 2

[Joan Montané]

(In reply to Rudy Lu [:rudyl] from comment #1)

> Do we need to separate this into another keyboard layout or just add these
> alternative chars into Spanish keyboard?

These chars are needed in the Spanish keyboard, because Catalan users may use Spanish keyboard to type booth in Spanish and Catalan. Also, Catalan load words are written in Spanish language, for example: "Avinguda Paral·lel", a famous road in Barcelona.

An own Catalan keyboard can be useful too, but layout can be different.

Comment 3

[Toni Hermoso Pulido]

Hi, any comment so far, Casey, Rafael?

Comment 4

[Guillermo López :willyaranda (probably SLOW response)]

Adding some TEF folks to see if they can move this forward or if they want it for v1.

Comment 5

[Toni Hermoso Pulido]

Hi, anything could we contribute to? Thanks!

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Also cc Stas, since this may require some l10n string to added into the settings if we want to add a new layout of Catalan.

Comment 7

[Toni Hermoso Pulido]

(In reply to Rudy Lu [:rudyl] from comment #6)
> Also cc Stas, since this may require some l10n string to added into the
> settings if we want to add a new layout of Catalan.

Rudy, from your comment, should I understand that would be worth start preparing a Catalan layout (and fill maybe another bug as well) ?

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Toni Hermoso Pulido from comment #7)
> (In reply to Rudy Lu [:rudyl] from comment #6)
> > Also cc Stas, since this may require some l10n string to added into the
> > settings if we want to add a new layout of Catalan.
> 
> Rudy, from your comment, should I understand that would be worth start
> preparing a Catalan layout (and fill maybe another bug as well) ?

We may need UX's input to make the final call.
Also ni to Casey.

Comment 9

[Casey Yee]

I'm not comfortable making this call since I am not a Spanish keyboard user.

I defer to TEF's recommendation on this one.

cc. Rafael.

Comment 10

[Guillermo López :willyaranda (probably SLOW response)]

Since TEF will ship phones in Spain, should we tef+?

Comment 11

[Daniel Coloma:dcoloma]

I think is quite late in the game to add this to v1.0.1 or even in v1.1 (nominating for leo just in case)

Comment 12

[Peter Dolanjski [:pdol]]

Catalan is not one of the Tef or Leo agreed upon supported languages, so not a blocker for release.  Tracked instead.

Comment 13

[Toni Hermoso Pulido]

Anything we can do to help you? Let us know. Thanks in advance!

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

According to Comment 2, maybe for v1, we could just add those characters to Spanish layout.
I would plan to add:

"ŀ"  as one of the alternative char for "l".
"·" as another for ".".

also +cc Francisco, for keyboard UX related issue.

Comment 15

[Joan Montané]

> I would plan to add:
> 
> "ŀ"  as one of the alternative char for "l".

Avoid using "ŀ" character, it's a little nightmare character in Unicode for compatibilty with legacy codepages. Instead, add "l·l" (3 characters) as alternative for "l".

> "·" as another for "."

That's fine, :)

Comment 16

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9407

Pointer to Github pull-request

Comment 17

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 741789 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9407

Add "l·l" (3 chars) and "·".

Who could help to review this simple patch?
Thanks in advance.

Comment 18

[Francis Djabri [:djabber]]

Hi, imagine that this is a politically sensitive issue. Like Casey, I don't feel able to make this one and would prefer to defer to Rafael. 

However, for what it's worth, it makes sense to me to start preparing a distinct Catalan keyboard for those Catalan speakers who wish to have it. The question is whether we should include the Catalan specific characters to the Spanish keyboard - this seems harmless enough to me, but I'm unsure if this would cause offense to a Spanish or Catalan speaker. 

Francis

Comment 19

[Toni Hermoso Pulido]

(In reply to Francis Djabri [:djabber] from comment #18)
> Hi, imagine that this is a politically sensitive issue. Like Casey, I don't
> feel able to make this one and would prefer to defer to Rafael. 
>
> However, for what it's worth, it makes sense to me to start preparing a
> distinct Catalan keyboard for those Catalan speakers who wish to have it.
> The question is whether we should include the Catalan specific characters to
> the Spanish keyboard - this seems harmless enough to me, but I'm unsure if
> this would cause offense to a Spanish or Catalan speaker. 
> 

Hi Francis,

I think that Joan, Eduard and me can tell you that this 2 lines patch would not be any offence to any sane Catalan speaker (and we speak Spanish as well — indeed, Spanish is my mother tongue). Let's see what others can tell.

Comment 20

[Joan Montané]

(In reply to Toni Hermoso Pulido from comment #19)

> I think that Joan, Eduard and me can tell you that this 2 lines patch would
> not be any offence to any sane Catalan speaker (and we speak Spanish as well
> — indeed, Spanish is my mother tongue). Let's see what others can tell.

I full agree with Toni. Because urrent Spanish keyboard has several alternative chars for writing loan words from many other Latin-based languages, I see no headache adding "l·l" to allow write words borrowed from Catalan.

IMHO, "l·l" is more usefull in a Spanish keyboard than "ê", "ë", "ē" or "ę" chars, for instance.

Current non-Spanish characters available at Spanish keyboard as alternative chars:

      a: àâäåãāæ
      c: ç
      e: èêëēęɛ'
      i: ïìîīį
      o: öòôōœøɵ
      u: ùûū
      s: ßš
      l: £
      n: ń
      y: ¥
      r: "R$"
     
Note: "à", "è", "ï", "ò" and "ç" chars are used to type in Catalan (and may be in other languages too) and they are already in Spanish keyboard.

Comment 21

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V.1 - add the alternative chars of Catalan to Spanish

Hi Stas,

Still not sure who is the best candidate to review this.
Could you help (again) on this?

Thank you.

Comment 22

[Staś Małolepszy :stas]

Comment on attachment 742889 [details] [diff] [review]
Patch V.1 - add the alternative chars of Catalan to Spanish

Review of attachment 742889 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Toni, would you mind filing a new bug about creating a separate Catalan layout as well?

::: apps/keyboard/js/layout.js
@@ +194,4 @@
>        o: 'óºöòôōœøɵ',
>        u: 'üúùûū',
>        s: '$ßš',
> +      l: '£ l·l',

"l·l" being three chars, is it inputted as a whole thanks to the space before it?

@@ +198,1 @@
>        n: 'ń',

Not related to this bug, but how come the Spanish layout doesn't have the "ñ"?

Comment 23

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Staś Małolepszy :stas (needinfo along with cc, please; if you want an r+ from me, attach your patch to the bug; I don't review pull requests) from comment #22)
> Comment on attachment 742889 [details] [diff] [review]
> Patch V.1 - add the alternative chars of Catalan to Spanish
> 
> Review of attachment 742889 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me
> 
> Toni, would you mind filing a new bug about creating a separate Catalan
> layout as well?
> 
> ::: apps/keyboard/js/layout.js
> @@ +194,4 @@
> >        o: 'óºöòôōœøɵ',
> >        u: 'üúùûū',
> >        s: '$ßš',
> > +      l: '£ l·l',
> 
> "l·l" being three chars, is it inputted as a whole thanks to the space
> before it?

Yes, exactly as you said.

> 
> @@ +198,1 @@
> >        n: 'ń',
> 
> Not related to this bug, but how come the Spanish layout doesn't have the
> "ñ"?

This is because "ñ" has been added as the 10th key of the 2nd row.
So, it would not be listed as an alternative char here.

Thanks.

Comment 24

[Guillermo López :willyaranda (probably SLOW response)]

(In reply to Staś Małolepszy :stas (needinfo along with cc, please; if you want an r+ from me, attach your patch to the bug; I don't review pull requests) from comment #22)
> 
> Not related to this bug, but how come the Spanish layout doesn't have the
> "ñ"?

The Spanish keyboard has a 'ñ' key next to the 'l', we don't need to long press 'n' anymore! :D

Comment 25

[Toni Hermoso Pulido]

(In reply to Staś Małolepszy :stas (needinfo along with cc, please; if you want an r+ from me, attach your patch to the bug; I don't review pull requests) from comment #22)

> 
> Toni, would you mind filing a new bug about creating a separate Catalan
> layout as well?
> 

Thanks. Perfect! We'll prepare and test it and we'll come back to you in another bug.

Comment 26

[Francis Djabri [:djabber]]

> 
> Hi Francis,
> 
> I think that Joan, Eduard and me can tell you that this 2 lines patch would
> not be any offence to any sane Catalan speaker (and we speak Spanish as well
> — indeed, Spanish is my mother tongue). Let's see what others can tell.

Hi Toni, Joan, 

Thank you for resolving this, sounds great to me.

Comment 27

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Seems everyone agreed on this modification.

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/2aa6d9e898ee49e87cf38f697b6290019987753e

Thank you all.

Comment 28

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Clear the ni since this has been fixed.