845335 - Manifest change for supporting small-screens (LDPI)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

http://mxr.mozilla.org/mozilla-beta/source/mobile/android/base/AndroidManifest.xml.in#12

I believe this needs to be toggled otherwise devices trying to download Firefox will get 'unsupported due to manifest' messages on Google Play.

Comment 1

[Alex Keybl [:akeybl]]

The first opportunity we'll have to fix this is FF20b3 (going to build on Tuesday). Mark/Brad probably won't be able to address this before Monday due to MWC, but it's possible that Matt can help push a patch along (or tell us why this isn't the correct path forward).

Comment 2

[Aaron Train [:aaronmt]]

Context in email I sent out, bug 845307 was filed from a user with a device meeting system requirements but not meeting manifest spec on Google Play (unable to download Firefox). I believe the store is looking at http://mxr.mozilla.org/mozilla-beta/source/mobile/android/base/AndroidManifest.xml.in#12
and blocking the device; Galaxy Fit (320x240 QVGA). 

Fx20 supposedly supports QVGA displays (outlined in the release-notes) including 320x240 (~120 LDPI) as far as I know that's Android defined as 'small-screen'; but as far as I'm aware we don't support LDPI yet (Sriram says MDPI is downscaled, but I thought we were waiting on bug 795408). If we support QVGA; 480x640 (HDPI), I believe we still need to flip that manifest setting.

http://developer.android.com/guide/practices/screens_support.html (was using Table 3 near the bottom for info)

Comment 3

[Brian Nicholson (:bnicholson)]

Attachment: Add back support for small screens

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 719216 [details] [diff] [review]
Add back support for small screens

Let's hope we have all the required resources for this to work...

Comment 5

[Aaron Train [:aaronmt]]

As far as I can recall, the only suck with small-screens is bug 840593

Comment 6

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/caabb125d096

Comment 7

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/caabb125d096

Comment 8

[Brian Nicholson (:bnicholson)]

Comment on attachment 719216 [details] [diff] [review]
Add back support for small screens

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 805191
User impact if declined: phones with small screens can't use Fennec
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): unknown - have no small screen phones to test
String or UUID changes made by this patch: none

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 719216 [details] [diff] [review]
Add back support for small screens

Approving this for uplift assuming that QA will find a device (or a community member) who can verify this.

Comment 10

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-beta/rev/ccf5e685ee27

Comment 11

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cc602a4fd6d7

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

We're waiting for verification here in order to resolve bug 845307.

Comment 13

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

firefox 20 beta 4 is offered to me by google play store on my Samsung Galaxy Mini (ARMv6, 384MB RAM, QVGA), so i guess that's one data point towards setting this bug to verified. What are the criteria? Two or more armv6 384mb, qvga devices tested successfully? or is 1 sufficient?

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

This is already in the relnotes as "System requirements have been lowered to 384MB of RAM and QVGA displays"