84535 - Search UI: File result to POP acct level crashes.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[laurel]

Using jun7 commercial branch
Assume it happens on trunk, too.

I don't know if this is due to the lack of fix for bug 74406 (which might
prohibit filing to account level). Note that we pushed target milestone for
74406 to 0.9.3 (past commercial RTM).

Because of lack of fix for 74406 it is hard to select the account level, but it
can be done by accident (I did).

Problem description:  If you file a search result to POP account acct level, a
crash occurs.  Note: filing to IMAP acct level will error with "mailbox doesn't
exist".

Steps:
1.  Go to mail window, login to POP account.
2.  Search|Search Mail/News Messages, initiate a simple search for the POP
account which will yield matches.
3.  Select a message in the search results pane and click File.  Select the POP
account level as the destination for the move.  Note:  the account level is not
specified with text, but there is a selectable space above the separator.

Result: crash occurs.

Comment 1

[laurel]

Attachment: TB 31456194

Comment 2

[laurel]

CLarification:  Only POP and Local Folders acct level as file search result
destinations crash.  Newsgroups or news servers (see bug 76401) and Webmail acct
levels don't error, don't crash, and don't do anything adverse.  AOL acct and
IMAP acct levels error and don't do anything advers.

Comment 3

[Navin Gupta]

I will attach a patch to prevent the crash which is the right thing to do for 
now. Solving this problem from the FE may take more time because the XUL 
templates are almost the same for both 3-pane and search window, but it is not
working for search window.

Comment 4

[Navin Gupta]

Attachment: proposed fix

Comment 5

[Navin Gupta]

assert and return if destination folder is rootfolder. Need r & sr from bhuvan 
and david. 

Comment 6

[racham]

Yes. We should atleast prevent the crash from occuring in the current UI.
Though, it is unlikely that any user is going to select the account level due to
existing UI mess up, it will be nice to have protection in the backend to
prevent any filing activities at account level. I am hoping to find possible
solutions for the File button template UI weirdness once my current bugs are done...

bhuvan

Comment 7

[scottputterman]

moving to 0.9.2

Comment 8

[racham]

r=bhuvan

Comment 9

[scottputterman]

hey, you overwrote my changes!

Comment 10

[David :Bienvenu]

have you checked that this works? comparing two comptr's for equality like this?
If so, sr=bienvenu and I notice you're checking in that null check for newHdr,
which is a good thing too.

Comment 11

[Navin Gupta]

Attachment: revised patch. grrrr!

Comment 12

[Navin Gupta]

better fix. I have seen places where we do compare for comptrs equality and it 
works!!

Comment 13

[David :Bienvenu]

I don't know that it doesn't work, but I just wanted to be sure. sr=bienvenu

Comment 14

[racham]

Sorry Scott. I promise that was an accident..!

Comment 15

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 16

[Navin Gupta]

fix checked in. 

Comment 17

[laurel]

OK, no crash, using june 14 commercial trunk builds: win98, mac OS 9.0, linux rh6.2

Comment 18

[Navin Gupta]

*** Bug 83886 has been marked as a duplicate of this bug. ***