845466 - [CTP] Click-To-Play: String for enabling Java uses 'Java(TM) Platform SE 7 U' as plugin name

Status: RESOLVED INVALID

(Firefox :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Click-To-Play uses 'Java(TM) Platform SE 7 U' as plugin name for enabling Java.

Code:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-plugins.js#70

makeNicePluginName : function (aName) {
  if (aName == "Shockwave Flash")
    return "Adobe Flash";

  // Clean up the plugin name by stripping off any trailing version numbers
  // or "plugin". EG, "Foo Bar Plugin 1.23_02" --> "Foo Bar"
  // Do this by first stripping the numbers, etc. off the end, and then
  // removing "Plugin" (and then trimming to get rid of any whitespace).
  // (Otherwise, something like "Java(TM) Plug-in 1.7.0_07" gets mangled)
  let newName = aName.replace(/[\s\d\.\-\_\(\)]+$/, "").replace(/\bplug-?in\b/i, "").trim();
  return newName;
},

Should this be added after the Flash test?
  if (aName.startsWith("Java(TM) Platform SE ")
    return "Java";

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Of course there should be a second closing parenthesis in line 1

Comment 2

[Mats Palmgren (inactive)]

We're in the process of removing support for plugins (bug 1677160), so I think this bug is irrelevant now.