Closed Bug 845511 Opened 11 years ago Closed 11 years ago
Regular Tabs, Private Tabs, and Remote Tabs buttons are missing accessibility labels
The buttons for regular tabs, private tabs and remote tabs do not have proper accessibility contentDescription associations. Also, it is not indicated which is the active tab. The buttons I'm referring to are those in the tabs panel at the top to the left of the "new tab" button. While we're here, it should also be made sure that all UI elements are accessible, like the "Close all" button which I have not seen with TalkBack at all.
Sriram - Let's try to get a patch and uplift for Beta... soon
Assignee: nobody → sriram
@Kevin, Firefox for desktop is not affected by this bug, it is specifically one for Firefox for Android's UI.
setContentDescription() added to the buttons.
This is a bit cleaner approach.
Option 2 feels better (had to refresh the patch).
Comment on attachment 719717 [details] [diff] [review] Patch: Option 2 Yeah, I agree. Clean.
Attachment #719717 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Comment on attachment 719717 [details] [diff] [review] Patch: Option 2 [Approval Request Comment] Bug caused by (feature/regressing bug #): New tab panels (Private browsing tabs etc.) User impact if declined: Blind users won't know which button activates which type of tabs. Testing completed (on m-c, etc.): Yes. Risk to taking this patch (and alternatives if risky): None, simple addition of contentDescriptions. String or UUID changes made by this patch: None. Strings that are spoken are already present.
Landed on Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/d18a62362aab
Pushed to beta: https://hg.mozilla.org/releases/mozilla-beta/rev/b8a9b1a5f454
Verified fix on Aurora 21.0a2 2013-03-14 and Firefox Mobile 20 beta 5 on the Samsung Galaxy Tab 2 7.0 (Android 4.1.1)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.