84564 - Content-Style-Type no longer working

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Hixie (not reading bugmail)]

STEPS TO REPRODUCE
   http://www.bath.ac.uk/%7Epy8ieh/internet/importtest/main/defaultlanguage.html

ACTUAL RESULTS
   Red.

EXPECTED RESULTS
   Green.

Comment 1

[Hixie (not reading bugmail)]

The original bug was bug 1962. It was VERIFIED FIXED a long time ago.

cc'ing peterv, harishd, attinasi, dbaron: Any of you know how Content-Style-Type
broke or how to fix it?

Comment 2

[Hixie (not reading bugmail)]

See also: 
http://www.bath.ac.uk/~py8ieh/internet/importtest/extra/defaultlanguage.http.htm
l

Comment 3

[Peter Van der Beken [:peterv]]

Something weird is happening in nsGenericHTMLElement::ParseStyleAttribute. After
the following lines, isCSS is true even if styleType is "text/nosense".

nsAutoString  styleType;
mDocument->GetHeaderData(nsHTMLAtoms::headerContentStyleType, styleType);
if (0 < styleType.Length()) {
  static const char* textCssStr = "text/css";
  isCSS = styleType.EqualsIgnoreCase(textCssStr, sizeof(textCssStr));
}

I have a patch, but I'm a bit worried that this code stopped working, so I am
going to cc Scc.
Scott: any idea why the EqualsIgnoreCase above always returns true?

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: Use new string functions

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

sizeof(char*) == 1

If you use char[] you can avoid that.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Then again, I think the patch you posted is better.  r=dbaron

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

er, 4 :-)

Comment 8

[Peter Van der Beken [:peterv]]

Thanks for pointing that out, David. Seems this broke when Pierre checked in his
fix for bug 63502.
Marc, could you please sr?

Comment 9

[Peter Van der Beken [:peterv]]

I'll take this.

Comment 10

[Peter Van der Beken [:peterv]]

Attachment: And fix the same mistake a bit further down

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

r=dbaron

Comment 12

[Marc Attinasi]

sr=attinasi

Comment 13

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 14

[Peter Van der Beken [:peterv]]

Checked in.

Comment 15

[Madhur Bhatia]

v