Closed Bug 845711 Opened 11 years ago Closed 11 years ago

Get correct EXTRA_GYP_DEFINES for arm

Categories

(Core :: WebRTC, defect)

Product:
Core
Component:
WebRTC
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: slee, Assigned: slee)

References

Details

(Whiteboard: [WebRTC] [blocking-webrtc-][android-webrtc+][qa-])

Attachments

(1 file)

patch
996 bytes, patch
ted
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
operator "+=" seems only available on bash. On shell, we should not use it.
Attachment #718858 - Flags: review?(ted)
I'll note that alder (being used by the Android people as a sandbox) doesn't use +=, and there are no other uses in configure.in
blocking- for desktop, but needed for b2g (and likely android)
Whiteboard: [WebRTC] [blocking-webrtc-]
Whiteboard: [WebRTC] [blocking-webrtc-] → [WebRTC] [blocking-webrtc-][android-webrtc+]
I wonder if this is why I'm having problems building on my Ubuntu box (dash)...was using Debian which has bash everywhere before.
Blocks: 845814
Comment on attachment 718858 [details] [diff] [review]
patch

Review of attachment 718858 [details] [diff] [review]:
-----------------------------------------------------------------

Apparently the patch in bug 818843 has these same changes, but it didn't stick.
Attachment #718858 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/ddd9cd9685bf
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Whiteboard: [WebRTC] [blocking-webrtc-][android-webrtc+] → [WebRTC] [blocking-webrtc-][android-webrtc+][qa-]
You need to log in before you can comment on or make changes to this bug.