Closed
Bug 845711
Opened 12 years ago
Closed 12 years ago
Get correct EXTRA_GYP_DEFINES for arm
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: slee, Assigned: slee)
References
Details
(Whiteboard: [WebRTC] [blocking-webrtc-][android-webrtc+][qa-])
Attachments
(1 file)
|
996 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
operator "+=" seems only available on bash. On shell, we should not use it.
Attachment #718858 -
Flags: review?(ted)
|
||
Comment 1•12 years ago
|
||
I'll note that alder (being used by the Android people as a sandbox) doesn't use +=, and there are no other uses in configure.in
|
|
||
Comment 2•12 years ago
|
||
blocking- for desktop, but needed for b2g (and likely android)
Whiteboard: [WebRTC] [blocking-webrtc-]
|
|
||
Updated•12 years ago
|
Whiteboard: [WebRTC] [blocking-webrtc-] → [WebRTC] [blocking-webrtc-][android-webrtc+]
|
||
Comment 3•12 years ago
|
||
I wonder if this is why I'm having problems building on my Ubuntu box (dash)...was using Debian which has bash everywhere before.
|
||
Comment 4•12 years ago
|
||
Comment on attachment 718858 [details] [diff] [review]
patch
Review of attachment 718858 [details] [diff] [review]:
-----------------------------------------------------------------
Apparently the patch in bug 818843 has these same changes, but it didn't stick.
Attachment #718858 -
Flags: review?(ted) → review+
|
|
||
Comment 5•12 years ago
|
||
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
||
Updated•12 years ago
|
Whiteboard: [WebRTC] [blocking-webrtc-][android-webrtc+] → [WebRTC] [blocking-webrtc-][android-webrtc+][qa-]
|
|
||
Updated•12 years ago
|
Blocks: android-webrtc
You need to log in
before you can comment on or make changes to this bug.
Description
•