Closed
Bug 845712
Opened 11 years ago
Closed 11 years ago
Fix some warnings in SIPCC Darwin code
Categories
(Core :: WebRTC: Signaling, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: cpeterson, Assigned: cpeterson)
Details
(Whiteboard: [qa-])
Attachments
(2 files)
4.03 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
1.28 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #718859 -
Flags: review?(rjesup)
Assignee | ||
Comment 1•11 years ago
|
||
threadPtr->name will be uninitialized if cprCreateThread()'s optional name parameter is NULL.
Attachment #718860 -
Flags: review?(rjesup)
Assignee | ||
Comment 2•11 years ago
|
||
The first patch (remove-pointer-casts.patch) fixes the following clang warning: media/webrtc/signaling/src/sipcc/cpr/darwin/cpr_darwin_threads.c:117:18 [-Wint-conversion] incompatible integer to pointer conversion passing 'uint64_t' (aka 'unsigned long long') to parameter of type 'pthread_t' (aka 'struct _opaque_pthread_t *') The other casts can be removed because C always void and non-void pointers to be used together without casts, unlike C++.
Updated•11 years ago
|
Attachment #718859 -
Flags: review?(rjesup) → review+
Updated•11 years ago
|
Attachment #718860 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/848ea76791dd https://hg.mozilla.org/integration/mozilla-inbound/rev/5d7eb9cfdaa8
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/848ea76791dd https://hg.mozilla.org/mozilla-central/rev/5d7eb9cfdaa8
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•