Refactor FB import to use the new generic importer and connector architecture

RESOLVED FIXED

Status

Firefox OS
Gaia::Contacts
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jose Manuel Cantera, Assigned: Jose Manuel Cantera)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(blocking-b2g:-, b2g18+ fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
It is needed to:

+ Create a Connector for Facebook
+ Refactor the current code to use import.html and importer_ui.js. Removing all possible duplications.
(Assignee)

Updated

5 years ago
Depends on: 843505
(Assignee)

Comment 1

5 years ago
needed for leo in order to keep things clean and not having duplicate code
blocking-b2g: --- → leo?
(Assignee)

Comment 2

5 years ago
Created attachment 721271 [details]
Pointer to GH PR
Attachment #721271 - Flags: review?(francisco.jordano)
Attachment #721271 - Flags: review?(crdlc)
Attachment #721271 - Flags: review?(francisco.jordano) → review+
Attachment #721271 - Flags: review?(crdlc) → review+
(Assignee)

Comment 3

5 years ago
https://github.com/mozilla-b2g/gaia/commit/23988798926386a3f9048bddf5000c41f4d088c4
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

5 years ago
this should be also leo+ for the sake of maintaniability and sustainability of the version

Comment 5

5 years ago
Tracking but not blocking - this can land today still since it was resolved on master a week ago.
blocking-b2g: leo? → -
tracking-b2g18: --- → +

Updated

5 years ago
Keywords: checkin-needed
I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 23988798926386a3f9048bddf5000c41f4d088c4
  <RESOLVE MERGE CONFLICTS>
  git commit

Alex, not sure why you set the checkin-needed keyword here...
Keywords: checkin-needed
Uplifted commit 23988798926386a3f9048bddf5000c41f4d088c4 as:
v1-train: d674a3526fbf1a03b34a1e8dc26523e74d6037f0
status-b2g18: --- → fixed
(Assignee)

Comment 8

5 years ago
In v1-train the commit really was 

https://github.com/mozilla-b2g/gaia/commit/dcbcdfc053a39ca9500a43b78d5ea3e0326a1fba
You need to log in before you can comment on or make changes to this bug.