845777 - Refactor FB import to use the new generic importer and connector architecture

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

It is needed to:

+ Create a Connector for Facebook
+ Refactor the current code to use import.html and importer_ui.js. Removing all possible duplications.

Comment 1

[Jose Manuel Cantera]

needed for leo in order to keep things clean and not having duplicate code

Comment 2

[Jose Manuel Cantera]

Attachment: Pointer to GH PR

Comment 3

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/23988798926386a3f9048bddf5000c41f4d088c4

Comment 4

[Jose Manuel Cantera]

this should be also leo+ for the sake of maintaniability and sustainability of the version

Comment 5

[Alex Keybl [:akeybl]]

Tracking but not blocking - this can land today still since it was resolved on master a week ago.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 23988798926386a3f9048bddf5000c41f4d088c4
  <RESOLVE MERGE CONFLICTS>
  git commit

Alex, not sure why you set the checkin-needed keyword here...

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 23988798926386a3f9048bddf5000c41f4d088c4 as:
v1-train: d674a3526fbf1a03b34a1e8dc26523e74d6037f0

Comment 8

[Jose Manuel Cantera]

In v1-train the commit really was 

https://github.com/mozilla-b2g/gaia/commit/dcbcdfc053a39ca9500a43b78d5ea3e0326a1fba