845805 - Add a By class to the marionette python bindings

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[Florin Strugariu [:Bebe]]

It would be nice to have access to a By class similar to the one found in the Selenium Python bindings.

Selenium class:
http://selenium.googlecode.com/svn/trunk/docs/api/py/_modules/selenium/webdriver/common/by.html#By

This class will abstract all the selector types and will help us write locators in a more elegant and easy way.

Comment 1

[David Burns :automatedtester]

If we add a class to http://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/ then we should be able to do this. The class just removes the potential issue with people putting their own strings in.

Comment 2

[Florin Strugariu [:Bebe]]

Attachment: Patch v1.0

I added the requested class

Comment 3

[David Burns :automatedtester]

This looks ok, can you update some of the tests so I can push this to try for you and see if it works when being referenced from other files

Comment 4

[Jonathan Griffin (:jgriffin)]

I don't think we can take a copyrighted file, reproduce it exactly, but change the license header to ours.  If we want this file, we should just copy it exactly (including license notices) from upstream.

Comment 5

[Karl Dubost]

Agreed with Jonathan terms 3 of Apache License for Distribution.

"You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works"

Comment 6

[Florin Strugariu [:Bebe]]

Sorry for this mistake guys I will update my patch.

Comment 7

[Florin Strugariu [:Bebe]]

I took a better look at the binding sand I found https://hg.mozilla.org/integration/mozilla-inbound/file/9a8d04f67e39/testing/marionette/client/marionette/marionette.py#l21

What I'm asking is implemented in the HTMLElement and used in https://hg.mozilla.org/integration/mozilla-inbound/file/9a8d04f67e39/testing/marionette/client/marionette/test_protocol.py#l46

I think this is a bad implementation because you would get access to all the methods in that class witch are not usable.

Comment 8

[David Burns :automatedtester]

:bebe

Please create the file, according to feed back above. 


(In reply to Florin Strugariu [:Bebe] from comment #7)

> What I'm asking is implemented in the HTMLElement and used in
> https://hg.mozilla.org/integration/mozilla-inbound/file/9a8d04f67e39/testing/
> marionette/client/marionette/test_protocol.py#l46

I think a better implementation is with a By too since HTMLElement.ID is ambiguous. Is it the mechanism to find or is it the elements ID. Please copy the Selenium file, licence and all, and update some tests so that we know that the egg is packaging them properly

Comment 9

[Florin Strugariu [:Bebe]]

Attachment: Parch version 1.1

I updated the license and modified the tests

Comment 10

[David Burns :automatedtester]

Comment on attachment 721133 [details] [diff] [review]
Parch version 1.1

> 
> class By(object):
>     ID = "id"
>     XPATH = "xpath"
>     LINK_TEXT = "link text"
>     PARTIAL_LINK_TEXT = "partial link text"
>     NAME = "name"


Please can we add the values and not just the top five. Also can you please update a few other test files, 2 files of your choosing.

Comment 11

[Florin Strugariu [:Bebe]]

Attachment: patch for Bug 845805 - Add a By class to the marionette python bindings

Comment 12

[Florin Strugariu [:Bebe]]

Attachment: Bug 845805 - Add a By class to the marionette python bindings

Comment 13

[David Burns :automatedtester]

pushed to try

https://tbpl.mozilla.org/?tree=Try&rev=637e7dcc5ff2
https://tbpl.mozilla.org/?tree=Try&rev=8a7aa0342814

Comment 14

[David Burns :automatedtester]

landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/a75301db9899

Comment 15

[(PTO May 7-12) Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a75301db9899