845806 - Report waitForText and waitForTest failures in robocop tests

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Geoff Brown [:gbrown]]

Robocop tests make frequent use of Solo.waitForText. waitForText returns a boolean which indicates if the text was found or not. Sometimes it is inconvenient to check the return value, and often a waitForText failure is not a good reason to assert. Still, this information may be important to diagnosing test behavior.

There is a similar issue with our own BaseTest.waitForTest.

Let's log waitForText/Test failures.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: log waitForText and waitForTest failures

Try run at https://tbpl.mozilla.org/?tree=Try&rev=4a6eeb44e118&noignore=1 has some interesting results, worth investigating in the near future.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 718965 [details] [diff] [review]
log waitForText and waitForTest failures

Review of attachment 718965 [details] [diff] [review]:
-----------------------------------------------------------------

this is great.  I would want to make sure all future tests (including patches already in progress) utilize waitForText vs solo.waitForText.

Comment 3

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/86811c639071

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/86811c639071