Closed Bug 845806 Opened 8 years ago Closed 8 years ago

Report waitForText and waitForTest failures in robocop tests

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 22

People

(Reporter: gbrown, Assigned: gbrown)

Details

Attachments

(1 file)

Robocop tests make frequent use of Solo.waitForText. waitForText returns a boolean which indicates if the text was found or not. Sometimes it is inconvenient to check the return value, and often a waitForText failure is not a good reason to assert. Still, this information may be important to diagnosing test behavior.

There is a similar issue with our own BaseTest.waitForTest.

Let's log waitForText/Test failures.
Try run at https://tbpl.mozilla.org/?tree=Try&rev=4a6eeb44e118&noignore=1 has some interesting results, worth investigating in the near future.
Attachment #718965 - Flags: review?(jmaher)
Comment on attachment 718965 [details] [diff] [review]
log waitForText and waitForTest failures

Review of attachment 718965 [details] [diff] [review]:
-----------------------------------------------------------------

this is great.  I would want to make sure all future tests (including patches already in progress) utilize waitForText vs solo.waitForText.
Attachment #718965 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/86811c639071
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.