Closed
Bug 845811
Opened 13 years ago
Closed 13 years ago
openLinkIn should use the target window's isBlankPageURL function
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 22
People
(Reporter: dao, Assigned: dao)
Details
Attachments
(1 file)
|
1.26 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
openLinkIn calls isBlankPageURL to determine whether it should raise the window and focus the location bar. isBlankPageURL returns true for about:newtab and false for about:privatebrowsing in non-private windows and vice versa in private windows. Therefore it should be called in the target window's context, as that may have a different privacy status than the current window.
Attachment #718968 -
Flags: review?(ehsan)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 718968 [details] [diff] [review]
patch
Review of attachment 718968 [details] [diff] [review]:
-----------------------------------------------------------------
Nice catch! How did you find this bug, out of curiosity?
Attachment #718968 -
Flags: review?(ehsan) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
(In reply to :Ehsan Akhgari from comment #1)
> Nice catch! How did you find this bug, out of curiosity?
Just by reading the code.
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
You need to log in
before you can comment on or make changes to this bug.
Description
•