openLinkIn should use the target window's isBlankPageURL function

RESOLVED FIXED in Firefox 22

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 22
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 718968 [details] [diff] [review]
patch

openLinkIn calls isBlankPageURL to determine whether it should raise the window and focus the location bar. isBlankPageURL returns true for about:newtab and false for about:privatebrowsing in non-private windows and vice versa in private windows. Therefore it should be called in the target window's context, as that may have a different privacy status than the current window.
Attachment #718968 - Flags: review?(ehsan)

Comment 1

6 years ago
Comment on attachment 718968 [details] [diff] [review]
patch

Review of attachment 718968 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!  How did you find this bug, out of curiosity?
Attachment #718968 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

6 years ago
(In reply to :Ehsan Akhgari from comment #1)
> Nice catch!  How did you find this bug, out of curiosity?

Just by reading the code.
https://hg.mozilla.org/mozilla-central/rev/bc4d875f93d5
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
You need to log in before you can comment on or make changes to this bug.