Last Comment Bug 845812 - Remove the magic overload module flag when running test from SDK root folder
: Remove the magic overload module flag when running test from SDK root folder
Status: RESOLVED WONTFIX
:
Product: Add-on SDK
Classification: Client Software
Component: General (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Alexandre Poirot [:ochameau]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-27 06:10 PST by Alexandre Poirot [:ochameau]
Modified: 2013-02-28 11:39 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Pull request 819 (165 bytes, text/html)
2013-02-27 06:28 PST, Alexandre Poirot [:ochameau]
rFobic: review-
Details

Description Alexandre Poirot [:ochameau] 2013-02-27 06:10:44 PST
Now that our test running pass --overload-modules to cfx, we should be able to get rid of the following magic code that allowed to land bug  without immediatly breaking tinderbox tests on nightly/aurora that weren't shipping required updated SDK modules:

https://github.com/mozilla/addon-sdk/blob/master/python-lib/cuddlefish/__init__.py#L789-L795
Comment 1 Alexandre Poirot [:ochameau] 2013-02-27 06:28:40 PST
Created attachment 718974 [details]
Pull request 819

Note You need to log in before you can comment on or make changes to this bug.