If the call to GfxInfoThread.getData happens before the thread is done it's gfx info gathering, severe badness happens. I don't think this happens too often in the wild thankfully, because gecko would have to start up really fast for it to get hit.
Attachment #719049 - Flags: review?(bjacob)
Note also that the InterruptedException blocks go away in bug 844275 part 7.
Attachment #719049 - Flags: review?(bjacob) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Comment on attachment 719049 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): 766251 User impact if declined: needed to uplift bug 844275 Testing completed (on m-c, etc.): on m-c, aurora try build at https://tbpl.mozilla.org/?tree=Try&rev=26b79db37644 Risk to taking this patch (and alternatives if risky): low risk, fennec only String or UUID changes made by this patch: none
Attachment #719049 - Flags: approval-mozilla-aurora?
Comment on attachment 719049 [details] [diff] [review] Patch well baked low risk patch(fennec only) needed to uplift bug 844275(recently approved for aurora)
Attachment #719049 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.