If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

TSan: Thread data race in set_mbuf_mb_args() vs. set_mbuf_mb_args()

RESOLVED FIXED in mozilla22

Status

()

Core
WebRTC
P2
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: posidron, Assigned: jesup)

Tracking

({sec-want})

Trunk
mozilla22
x86_64
Linux
sec-want
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tsan][tsan-test-blocker][webrtc][blocking-webrtc+][qa-], URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 719178 [details]
trace

During initial tests with ThreadSanitizer (LLVM version), we get a data race reported as described in the attached log. Trace was created on mozilla-central with changeset 122820:c233837cce08.

According to the TSan devs, most of the reported traces should be real data races, even though they can be "benign". We need to determine if the race can/should be fixed, or put on the ignore list. Even for benign races, TSan devs suggest to fix them (second priority), as they can also cause problems [1].

[1] http://software.intel.com/en-us/blogs/2013/01/06/benign-data-races-what-could-possibly-go-wrong

Comment 1

5 years ago
Fixed upstream as
http://code.google.com/p/sctp-refimpl/source/detail?r=8432

Thanks for the report.

Best regards
Michael
(Assignee)

Updated

5 years ago
Assignee: nobody → rjesup
Priority: -- → P2
Whiteboard: [tsan][tsan-test-blocker] → [tsan][tsan-test-blocker][webrtc][blocking-webrtc+]
(Assignee)

Updated

5 years ago
Depends on: 855620
(Assignee)

Comment 2

5 years ago
Fixed by checkin for bug 855620
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22

Updated

5 years ago
Whiteboard: [tsan][tsan-test-blocker][webrtc][blocking-webrtc+] → [tsan][tsan-test-blocker][webrtc][blocking-webrtc+][qa-]
You need to log in before you can comment on or make changes to this bug.