846055 - Change text in app history when developer updates packaged app version

Status: RESOLVED FIXED

(Marketplace Graveyard :: Reviewer Tools, enhancement, P4)

Description

[Lisa Brewster [:adora]]

Today, it says "disabled by mozilla," which sounds like we pulled the app down for doing something nefarious.  More accurate text would be something like "superseded by version n+1."

Comment 1

[Bram Pitoyo [:bram]]

Makes sense to me, though I’ve not seen this message yet. Could you snap a screenshot of it in context of the app history page?

Comment 2

[Andrew Williamson [:eviljeff]]

For context, 'disabled by mozilla' is a reflection of the state id the version has in the DB - which is also used by apps/addons where it /does/ indicate we pulled the app/addon for doing something nefarious.  

Not that it stops us from changing the way its displayed of course.

Comment 3

[Andrew Williamson [:eviljeff]]

https://github.com/mozilla/zamboni/pull/901

Comment 4

[Andrew Williamson [:eviljeff]]

https://github.com/mozilla/zamboni/commit/13a62d8e7ccbf4c7576156d7152fd411cf9dca56
with some help from Kevin:
https://github.com/mozilla/zamboni/commit/43935dfb70fffeb6563a25081e767eda0f6e4773

Comment 5

[Victor Carciu]

I am not sure if I correctly understood the expected behavior here, but the "disabled by mozilla" text is still present in Manage Status&Versions developers  page : http://screencast.com/t/yrvICwRdSM

For this bug , I added a new version for a packaged app and verified the text for first version in app history and Status&Versions developers  page. Please let me know if my STRs are wrong.

Comment 6

[Andrew Williamson [:eviljeff]]

(In reply to Victor Carciu from comment #5)
> I am not sure if I correctly understood the expected behavior here, but the
> "disabled by mozilla" text is still present in Manage Status&Versions
> developers  page : http://screencast.com/t/yrvICwRdSM
> 
> For this bug , I added a new version for a packaged app and verified the
> text for first version in app history and Status&Versions developers  page.
> Please let me know if my STRs are wrong.

This bug is about the reviewer tools, or at least I guessed it was as that's the component Lisa filed it under.  The patches only touch the review page.

Comment 7

[Victor Carciu]

Lisa, what do you think?

Comment 8

[Lisa Brewster [:adora]]

I was only thinking about the review history page when I filed the bug, but the status name should be consistent on the developer facing side, too.

Discussion about all app status names is happening here:  https://bugzilla.mozilla.org/show_bug.cgi?id=895560#c10

Comment 9

[Andrew Williamson [:eviljeff]]

adding a depends - no point in making more changes till the names are settled.

Comment 10

[Andrew Williamson [:eviljeff]]

resolving this bug for the original patch (reviewer tools) but the developer page work has been superseded by changes in bug 895560 to have an 'obsolete' state.