If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Allow RemoveListener() on Destroy()ed MediaStreams

RESOLVED FIXED in mozilla22

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

Trunk
mozilla22
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 719261 [details] [diff] [review]
Make RemoveListener not assert on a Destroyed MediaStream (note: not tested)

It would make cleanup code simpler if RemoveListener() on a MediaStream Destroy()ed by the DOMMediaStream didn't cause an assertion.  It should just silently return, as we already remove all listeners on Destroy().

Note that the listeners might not actually be removed yet, but when they are you will get NotifyRemoved as usual.
Attachment #719261 - Flags: review?(roc)
(In reply to Randell Jesup [:jesup] from comment #0)
> Note that the listeners might not actually be removed yet, but when they are
> you will get NotifyRemoved as usual.

This is normally what happens when you call RemoveListener().
Attachment #719261 - Flags: review?(roc) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8a1e08cc3ac
Target Milestone: --- → mozilla22
https://hg.mozilla.org/mozilla-central/rev/a8a1e08cc3ac
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.