846186 - Tilt error flooding error console (TypeError: mouseLerp is undefined)

Status: RESOLVED FIXED

(Firefox Graveyard :: Developer Tools: 3D View, defect)

Description

[Justin Dolske [:Dolske]]

I happened to use Tilt yesterday (for the first time in eons, I'm not a regular). I just now opened my Error Console to investigate a separate issue (I think -- cut'n'paste not working), and noticed that it's being absolutely _flooded_ with error messages.

I am literally seeing dozens and dozens of these fly by -- if I clear the messages, the scrollbar shrinks rapidly to it's minimum state within seconds. I also GC/CC debug messages scroll by every couple seconds (I have that pref enabled). The good news is that the browser seems quite responsive!

But this is clearly not a good thing.

Comment 1

[Justin Dolske [:Dolske]]

I was able to reproduce this after restarting my browser.

* Tools -> Web Dev -> Toggle Tools
* Click the cube button
* move the 3D view around a bit to bask in its glory
* Command-W to close the tab.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I saw this too, yesterday in Nightly.

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 4

[Victor Porof [:vporof][:vp]]

Happens in aurora and beta too. Boo.

Comment 5

[Rob Campbell [:rc] (:robcee)]

adding tracking flags. This affects aurora and beta.

Comment 6

[Victor Porof [:vporof][:vp]]

Thanks rob! 
Inbound and fx-team are CLOSED for now. Need to wait a bit.

Comment 7

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/9161ede810cb

Comment 8

[Victor Porof [:vporof][:vp]]

Comment on attachment 719396 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): closing a window with Tilt open results in a flood of TypeErrors in the Error Console
User impact if declined: Medium, not something a regular user may see, but having lots of errors rapidly showing up in the Error Console (if open) may affect browser responsiveness
Testing completed (on m-c, etc.): local, fx-team
Risk to taking this patch (and alternatives if risky): None, small simple change
String or UUID changes made by this patch: None

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9161ede810cb

Comment 10

[bhavana bajaj [:bajaj]]

Comment on attachment 719396 [details] [diff] [review]
v1

Please land before 3/5(tomorrow) for this to make into fx20 beta3 which goes to build tomorrow.

Comment 11

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d00c9c0c5a99
https://hg.mozilla.org/releases/mozilla-beta/rev/63ff1c6ed484

Comment 12

[Virgil Dicu [:virgil] [QA]]

Verified the large number of error messages for 2013-02-27 Nightly (20130227030925) by following the STR from comment 1.

Verified the fix for Latest Nightly (20130305030833), Latest Aurora (20130305042015) and Firefox 20.0 Beta 3 (20130305164032).

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0

Comment 13

[u279076]

Flagging for verification in Firefox 21 and 22.

Comment 14

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0

Comment 15

[Ioana (away)]

Verified as Fixed on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:21.0) Gecko/20100101 Firefox/22.0 - 20130514181517.

Comment 16

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old