Closed Bug 846187 Opened 7 years ago Closed 7 years ago

Email scrolling fps is too low: Decide on a UX compromise for text-overflow: ellipsis

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

x86_64
Linux
defect
Not set

Tracking

(blocking-b2g:tef+, b2g18 affected, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 affected)

RESOLVED WORKSFORME
blocking-b2g tef+
Tracking Status
b2g18 --- affected
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- affected

People

(Reporter: cjones, Unassigned)

References

Details

(Whiteboard: [leave open][target 28/2])

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #840372 +++

Leaving all the ellipses in the email list view costs anywhere from 4-10fps.  Removing all of them brings us full perf.  Removing two ought to help but may not have been tested independently.

So we should decide which patch to take.
m1, which one of these went into the MWC build?
Flags: needinfo?(mvines)
Patryk, can you confirm that UX is OK with disabling ellipsis for the message subject and snippet?  The screenshot from this is

attachment 713310 [details]
Flags: needinfo?(padamczyk)
(In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> m1, which one of these went into the MWC build?

attachment 719334 [details] [diff] [review]
Flags: needinfo?(mvines)
Comment on attachment 719333 [details] [diff] [review]
Disable all text-overflow: ellipsis

Thanks.
Attachment #719333 - Attachment is obsolete: true
Hey Chris, UX is 100% NOT okay with disabling ellipsis overflow. I even had a few people at MWC comment that they found a bug during my demo of the OS when I launched the email app > The list without ellipsis looks completely broken.
Flags: needinfo?(padamczyk)
The question was specifically about
 - leaving ellipsis *enabled* for sender
 - *disabling* for subject and message-snippet
Flags: needinfo?(padamczyk)
In bug 840431 comment 8, it's looking like this patch isn't much win on its own.
Ellipsis in lists is just a requirement. I can't recall another OS that doesn't have this feature for text truncation.
Flags: needinfo?(padamczyk)
Sounds like there are UX downsides and negligible performance upside. Should this be backed-out and closed?
This may be fixed by bug 840431.
Depends on: 840431
Now that bug 840431 is fixed let's get verification here.
Keywords: qawanted, verifyme
QA, can you please measure whether this still makes a difference. If not, we can close it (and back out if needed, but I think we already backed this out).
Keywords: verifyme
looks like bug 840431 got reopened.  Looks like it's not in build 3/11 of the v1 train anyhow, the patch looks like it's in MC.  I guess what I can do is get some FPS measurements in today's build and wait for the next patch to run in bug 840431.
Naoki, it looks like the changes in bug 840431 have landed on v1.0.1.  Can you measure again when you have a chance?  Thanks.
Sure.  I have to do this at home, since my camera that I shoot to test with is at home.
Post patch does seem be a bit faster on average.  There are less "stick" points.
Tested around the patch.  verified that it is faster.

While testing around patch, found difference in behavior in bug 824189 and bug 851154.  Neither bugs are related to the patch.
Keywords: qawanted
Can we close this now?
Yes, I don't think we need to do anything here.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
(cleaning up wontfix in the email app: changing to WFM since things got faster and there was nothing left to do)
Resolution: WONTFIX → WORKSFORME
You need to log in before you can comment on or make changes to this bug.