Steps to reproduce: 1.Go into Gallery and select an image to view; 2.tap button to go into eidt mode 3.landscape the phone Expected results: 1.the image shows correctly; Actual results: 1. the image shows reversal.
QA will verify this issue.
we add a screenshot to show this issue
Hi, all, Just update the test result. FYR. The build: 20130218070201 (Cannot reproduce) The latest build: 20130304230203 (Cannot reproduce, as attachment) Could you please provide the build number? Did the issue cause by special image file? Thanks!
[tef- for now because (1) we have no build information for where this issue is seen, and (2) it can't be reproduced according to comment 4. Once we have more details on whether this is still an issue at the tip please re-nom for tef+]
we use the new build(mozilla build id:20130304070202, AU031), it also has this bug. it can see screenshot in the attachment.
Diego, can you please try to dup this here? Given the builds in comment 4 and comment 7 are so close, wondering if perhaps this is a HWC issue?
Hi, all, Sorry for my jump in. I tried to reproduce this case today. But I still cannot reproduce this issue. Please refer to the following video. If I misunderstand any steps, please let me know. https://dc1.safesync.com/LMhMpYZW/Gallery_Edit_Function.3gp?a=o8JZONTVpvM Build: 20130311070204 (mozilla-b2g18_v1_0_1-unagi-eng) Gecko-revision="d28b134520501bc1b829f0e225a163a111520c70" Gaia-revision="f03bc0e8647f94ab133fe813d68500061c147681" Thanks! Best Regards, William
(assigning to Diego pending ni? response as this is blocking next steps here)
(tef+ assuming a successful reproduction on the tip CDR codebase by Diego on Monday)
I can reproduce when rotating the phone clockwise to landscape with HwcComposer2D enabled. The issue seems to be the rotation calculation in Hwc. I'll investigate and report back
Diego, were you able to find anything from investigating further?
I found the problem. HwcComposer2d is not handling the combination of rotation and Y-axis flip at the same time. Since this is an uncommon use case I'll just make it fallback to GPU rendering.
Actually, the deeper cause is that the image is not in a shared texture. This is a valid use case but not supported in HwcComposer2D. The solution is to look for a shared texture before attempting to render with Hwc. The patch is on its way.
Created attachment 728527 [details] [diff] [review] Verify the buffer descriptor is a shared texture
Firefox_Mozilla@126.com, Can you try out the patch?
Comment on attachment 728527 [details] [diff] [review] Verify the buffer descriptor is a shared texture Review of attachment 728527 [details] [diff] [review]: ----------------------------------------------------------------- Do we need to do something similar for the other layer types?
(In reply to Nick Cameron [:nrc] from comment #18) > Do we need to do something similar for the other layer types? Looks like ThebesLayer is missing this check too. Others already do. Good catch!
I am not showing the image in reverse, I am seeing that it stretches in different orientations and changes the image when I select effects in the v1 train build on unagi Gecko http://hg.mozilla.org/releases/mozilla-b2g18/rev/dec694d585e1 Gaia 5a31a56b96a8fc559232d35dabf20411b9c2ca1d BuildID 20130325070203 Version 18.0
Created attachment 729320 [details] [diff] [review] Verify the buffer descriptor is a shared texture Same as the patch r+'ed by ncameron only in hg friendly patch format. Carry over r+
#6862 test case created in moztrap to cover this use case.
Verified Fixed on Unagi: The device enters landscape mode and screen orientation is displayed correctly Unagi Build ID: 20130329070203 Kernel Date: Dec 5 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/56c922308fd1 Gaia: 0a9f78bffafda93a159c1f502e8b110c2f49a500