846261 - [OPEN_][call log]some call log can not be delete.(617002041389)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Firefox_Mozilla]

Attachment: logs

Steps to reproduce:
1.using IM to make a call to test device(the number is 075526772333 );
2.the test device answer the call and then hang up;
3.go into dialer-call log. Tap edit button and select all to delete;
4.close Caller Identification of sim card.
5.using other phones to make a call to test device;
6.answer or hang up this call(It is shown “unknown number” in call log).
7.go into dialer-call log. Tap edit button and select all to delete;
Expected results:
1.in step3 and step7, the call log can be deleted successful;
Actual results:
1.in step3 and step7, the call log can be not deleted;

Comment 1

[Firefox_Mozilla]

Attachment: screen shot

Comment 2

[Kai-Chih Hu [:khu]]

QA will verify this issue.

Comment 3

[William Hsu [:whsu]]

Hi, all,

I have double confirmed this case.
The build: 20130218070201 (Cannot reproduce)
The build: 20130304230203 (Latest build, I also cannot reproduce)
Could you please provide the build number?
Thanks!

Comment 4

[Michael Vines [:m1] [:evilmachines]]

[tef- for now because (1) we have no build information for where this issue is seen, and (2) it can't be reproduced according to comment 3.  Once we have more details on whether this is still an issue at the tip please re-nom for tef+]

Comment 5

[Firefox_Mozilla]

we use the new build(mozilla build id:20130304070202, AU031), it also can reproduce this bug.
we first close Caller Identification. Then use other device to call us. After end call, it will has a record which shown "unknown number" in call log. But when we tap edit button and tap "select all" to delete all call logs, "Unknown number" can not be deleted and also shown in call logs.

Comment 6

[Michael Vines [:m1] [:evilmachines]]

Hey Anshul, any chance this may be us?

Comment 7

[Daniel Coloma:dcoloma]

German, can you have a look at this one? Please use v1.0.1 build to test it!

Comment 8

[William Hsu [:whsu]]

Hi, all,

Sorry for my jump in.
I tried to reproduce this case today.
But I still cannot reproduce this issue.
Please refer to  the following video. Did I miss any steps?
https://dc1.beta.safesync.com/LMhMpYZW/Call_Log.3gp?a=VS6QD5GSfNo

Build: 20130311070204 (mozilla-b2g18_v1_0_1-unagi-eng)
Gecko-revision="d28b134520501bc1b829f0e225a163a111520c70"
Gaia-revision="f03bc0e8647f94ab133fe813d68500061c147681"

Thanks!


Best Regards,
William

Comment 9

[Germán Toro del Valle (:gtorodelvalle)]

Having a look at it... ;-)

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

Still having a look at it but let me share with you (if it helps) that there are only 2 cases when "Unknown number" is shown in the Call Log and both are (or should be) kind of "unusual":
1. There is an entry in the call registry IndexedDB with no number (way weird :-p) -> https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/recents.js#L554
2. The Utils.getPhoneNumberPrimaryInfo() function returns null (which means that there is a contact associated to the phone number, but when we are getting the info to show it in the Call Log this contact does not have a name, either a company, either a matching phone number (the one which caused match with the contact)) -> https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/recents.js#L669 (probably even weirder than the previous one)

[e-mail] , could you shed light on which of the scenarios you may be in? Thanks!

On the other hand, I get exactly the same behavior as William, this is, for me it is working fine ;-)

Comment 11

[William Hsu [:whsu]]

Hi, all,

Sorry! My bad.
Thanks for you reminder and help.
I reproduced this case at Taiwan site.
You point out an important information.
The incoming call must be "Unknown number"
If user(caller) hide the phone number then dial up, the receiver(test device) will show "Unknown number" and the record cannot be deleted.
I attached the video for your reference.
Thanks again!
----------------------------------------------
The reproduced steps.
1. Make a call to test device.
   (Please dial "#31#your_phone_number" at Taiwan site, the "#31#" can hide your phone number.)
2.The test device answer the call then hang up;
3.Go into dialer-call log. Tap "Edit" button and select all call log to delete

Comment 12

[William Hsu [:whsu]]

Attachment: Unknown - Call log

Comment 13

[Germán Toro del Valle (:gtorodelvalle)]

In fact, I just noticed that I am not able to call any phone number using the #31# prefix using the latest Gaia... I guess you called from another platform to the test device :-)

In case it gets confirmed, I'll fill a bug about that :-)

Comment 14

[William Hsu [:whsu]]

Yes, I called from another phone to the test device.
Appreciate your help! Have a nice day! :)

Best Regards,
William

Comment 15

[Germán Toro del Valle (:gtorodelvalle)]

Damn it! I just confirmed that we do not correctly deal with "hidden/unknown calls" no only when deleting them but also when grouping them... ;-999 I just filled bug 850170

Comment 16

[Germán Toro del Valle (:gtorodelvalle)]

I have this one fixed. Waiting on bug 850170 and the final grouping criteria for the "hidden calls" to delete the concrete entries depending on this grouping ;-)

Comment 17

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated PR.

Comment 18

[Jose Manuel Cantera]

Comment on attachment 724357 [details]
Associated PR.

r+ provided the comments in GH are addressed, particularly code clarity in selector generation

Comment 19

[Germán Toro del Valle (:gtorodelvalle)]

Merged! ;-) Thanks!

Comment 20

[Germán Toro del Valle (:gtorodelvalle)]

Final commit in master: https://github.com/gtorodelvalle/gaia/commit/0153c6cd6430fb5bc3bfde134ad20bf9b1da759d

Comment 21

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 9f410bd165e5e7b20790f6b9c4c00ccb7fddd567 as:
v1-train: f5aaa4e7652383ca66ece07d5b61f56709d91efd
v1.0.1: 176c7354461055307c80b583333bce696462ea2e

Comment 22

[Firefox_Mozilla]

we now only have the version(build id：20130310070203) which also has this issue. Later we will check in new build.

Comment 23

[Jeni]

This is verified fixed in Unagi MC Build 

Unagi Build ID: 20130328031116
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/mozilla-central/rev/962f5293f87f
Gaia: 2ca952bcca39eda4fa6693ee53cf8c7ec8a3bdcc

However issue still repros in 

Verified fixed on 
Unagi Build ID: 20130329070203
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/56c922308fd1
Gaia: 0a9f78bffafda93a159c1f502e8b110c2f49a500

and

Unagi Build ID: 20130329070203
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/5cc5df16447a
Gaia: 26b463f14caa11e0fc64fda09a17054da4bea68b

Comment 24

[Darren]

There is already a test case that covers this issue:
https://moztrap.mozilla.org/manage/cases/?filter-id=1307

Comment 25

[William Hsu [:whsu]]

Hi, Darren,

Thanks for your information(test case).
But the test steps seems to miss a trigger point of the bug.
Could we add some step below on it or create a new case to test it?

Title: [CALL LOG] Select and delete a "Unknown" call log
Description: It should be possible to select and delete call logs.
Precondition: Prepare two cell phone, we called Phone-A and Phone-B.
Steps:
1. Phone-B hide the phone number before dial up.
1. Use Phone-B to make a call to call Phone-A.
( On GSM system, you can append #31# before the phone number to hide your phone number
  ex: #31#0978725115, etc...
)
2. Phone-B hang up the call before Phone-A answer it.
3. Phone-A call log will show a record-"Unknown number", please delete the call log

Expected result:
The call log can be deleted.

Thanks! :)

Best Regards,
William

Comment 26

[Germán Toro del Valle (:gtorodelvalle)]

Hi John! I found some weird issues regarding this bug, its patch and mainly the uplifting :-O Basically, I am not able to find in Github the commits related to the uplifting to v1-train either to v1.0.1. Although the hash of the commit made to master is right (https://github.com/mozilla-b2g/gaia/commit/06e0e5ce42bdfb62bdbe38271de6b5b2d9e40e75), the one made to v1-train is not (https://github.com/mozilla-b2g/gaia/commit/06e0e5ce42bdfb62bdbe38271de6b5b2d9e40e75 returns a 404 code) as well as the one made to v1.0.1 (https://github.com/mozilla-b2g/gaia/commit/176c7354461055307c80b583333bce696462ea2e returns a 404 code). Am I missing anything here? Has this patch been uplifted to v1-train and v1.0.1? Thanks!

Comment 27

[Darren]

Created a new test case covering this issue:
https://moztrap.mozilla.org/manage/cases/?filter-id=6948
https://moztrap.mozilla.org/manage/cases/?filter-id=6950

Comment 28

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to gtorodelvalle from comment #26)
> Hi John! I found some weird issues regarding this bug, its patch and mainly
> the uplifting :-O Basically, I am not able to find in Github the commits
> related to the uplifting to v1-train either to v1.0.1. Although the hash of
> the commit made to master is right
> (https://github.com/mozilla-b2g/gaia/commit/
> 06e0e5ce42bdfb62bdbe38271de6b5b2d9e40e75), the one made to v1-train is not
> (https://github.com/mozilla-b2g/gaia/commit/
> 06e0e5ce42bdfb62bdbe38271de6b5b2d9e40e75 returns a 404 code) as well as the
> one made to v1.0.1
> (https://github.com/mozilla-b2g/gaia/commit/
> 176c7354461055307c80b583333bce696462ea2e returns a 404 code). Am I missing
> anything here? Has this patch been uplifted to v1-train and v1.0.1? Thanks!

I'm not sure what's going on here.  The commit you are referring to is not mentioned in this bug at all (06e0e5ce42bdfb62bdbe38271de6b5b2d9e40e75) before you mentioned it.

$ git branch --contains 06e0e5ce42bdfb62bdbe38271de6b5b2d9e40e75
* v1-train

The two commits from comment 21 weren't present and I'm not sure how or why they aren't.

I have redone the uplift:
v1-train: afb2e21c5f00cdac589e897976b0bfa1c6ab1a13
v1.0.1: b3eacf6db5d0f6c9d16f4e5f71acc0dcbecba534

Comment 29

[cbarker]

Verify requires International Sim

Comment 30

[Germán Toro del Valle (:gtorodelvalle)]

Jeez! My fault... ;-999 It seems I copied the wrong commits into my comment 26 probably due to having too many tabs open in my browser :-( I was referring to https://github.com/mozilla-b2g/gaia/commit/9f410bd165e5e7b20790f6b9c4c00ccb7fddd567 (which exists) and https://github.com/mozilla-b2g/gaia/commit/f5aaa4e7652383ca66ece07d5b61f56709d91efd and https://github.com/mozilla-b2g/gaia/commit/176c7354461055307c80b583333bce696462ea2e which do not. Thanks John for the new uplifting! ;-)

Comment 31

[John Hammink]

Can the reporter please verify this fix?  It requires your SIM and network.

Comment 32

[William Hsu [:whsu]]

Sorry for my jump in. Verified this bug.
Great! Happy to know we fixed the bug. Have a nice weekend.
Attach the screenshot.

* Test build:
1. mozilla-central-unagi/2013/04/2013-04-05-10-34-53
   -Mercurial-Information:
     + Gecko revision="40a228f74389"
     + Gaia revision="fc2f77af69be"
   - Git-Information:
     + Gecko revision="39839490f961009f7d0e259d85e6931cfd11263d"
     + Gaia revision="3f824d1dcb15c2c2f3e90483adc9f9d01f122477"

2. mozilla-b2g18_v1_0_1-unagi-eng/2013/04/2013-04-05-23-02-04
   -Mercurial-Information:
     + Gecko revision="18a7bfbdedd2"
     + Gaia revision="f6f9fdf86a5c"
   - Git-Information:
     + Gecko revision="fe6592bf7a145bdb6a0cc06a73879ab05ca4ef15"
     + Gaia revision="28c144fa7e8061ee6bcbbb47ca911ef33b87814b"


Best Regards,
William

Comment 33

[William Hsu [:whsu]]

Attachment: Deleting unknown call log

Comment 34

[Firefox_Mozilla]

we use the new build version and this issue has been fixed. Thanks!

Comment 36

[Sreenidhi]

Verified on an Inari with the following build information :

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6bac24e14538
Gaia   c883af5ecd0998f78d9aaa4c2337c842e1dbb5a0
BuildID 20130416070200
Version 18.0

Issue did not reoccur

Comment 37

[Johan Lorenzo [:jlorenzo]]

Shally, can you paste the revisions against which you verified?

Comment 38

[Shally Li（leave from Mozilla）]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #37)
> Shally, can you paste the revisions against which you verified?

Hi Johan,
 
    According to Comment 36 ,I delete the "Verifyme" in keywords and change "status-b2g18-v1.0.1: fixed" to "verified". And I can't verify this bug because I have no “b2g18-v1.0.1” device.

Comment 39

[Johan Lorenzo [:jlorenzo]]

Yes, these bugs were filed against really old versions. I was curious on how you'd verify this one :)

To make things more clear, I would suggest to put an additional comment like "Per comment X" when you flip an old status flag like this one. What do you think?

Comment 40

[Shally Li（leave from Mozilla）]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #39)
> Yes, these bugs were filed against really old versions. I was curious on how
> you'd verify this one :)
> 
> To make things more clear, I would suggest to put an additional comment like
> "Per comment X" when you flip an old status flag like this one. What do you
> think?

OK, thank you very much.