The default bug view has changed. See this FAQ.

Search Form Refinements

RESOLVED FIXED in 2013Q1

Status

support.mozilla.org
Knowledge Base Software
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: joshua, Assigned: joshua)

Tracking

unspecified
2013Q1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: u=user c=general p=0 s=2013.6 [mentor=r1cky])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Created attachment 719438 [details]
Example

This could be fixed by modifying the padding attribute on the search box.

I would like to fix this.
(In reply to Joshua Smith [:joshua-s] from comment #0)
> I would like to fix this.

It's yours!
Assignee: nobody → micovision
(Assignee)

Comment 2

4 years ago
Thanks!  Also, while we are refining the search box, do you think I should turn it and its contents into a class? (.search-form maybe?)

That would consolidate the code, and allow all search forms to use the same style.
(In reply to Joshua Smith [:joshua-s] from comment #2)
> Thanks!  Also, while we are refining the search box, do you think I should
> turn it and its contents into a class? (.search-form maybe?)
> 
> That would consolidate the code, and allow all search forms to use the same
> style.

That's a good idea. Go for it!
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 4

4 years ago
To work on this, do I need to delete my fork of kitsune and re-fork it? Or is there a way that I don't know about to update forked repos?
(Assignee)

Updated

4 years ago
Summary: Search text and icon overlap → Search Form Refinements
(Assignee)

Comment 5

4 years ago
Created attachment 722900 [details]
https://support.mozilla.org/search

Should I change this form or leave it as is?
Attachment #722900 - Flags: feedback?
(Assignee)

Updated

4 years ago
Attachment #722900 - Flags: feedback? → feedback?(rrosario)
(In reply to Joshua Smith [:joshua-s] from comment #5)
> Created attachment 722900 [details]
> https://support.mozilla.org/search
> 
> Should I change this form or leave it as is?

Leave that one as is for now. Thanks
Attachment #722900 - Flags: feedback?(rrosario) → feedback+
Landed on master:
https://github.com/mozilla/kitsune/commit/5de3c9303e2cc2e5f65b1d312667d2d7758adebb

With some tweaks:
https://github.com/mozilla/kitsune/commit/ce2a717f89d16a67ed3edb765a1e1ed8909ac076
Whiteboard: u=user c=general p=0 s=2013.6 [mentor=r1cky]
Target Milestone: --- → 2013Q1
Deployed to prod now.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.