Twitter OpenSearch appears to be busted

RESOLVED FIXED in Thunderbird 24.0

Status

Thunderbird
Search
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mconley, Assigned: Ekanan Ketunuti)

Tracking

Trunk
Thunderbird 24.0

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=mkmelin][string change only], URL)

Attachments

(1 attachment, 1 obsolete attachment)

STR:

1) In some message, select some text, and choose "Search X search for..." to open an OpenSearch tab
2) In the new tab, choose "Twitter"

What happens?

I get a "Sorry, that page doesn't exist!" error from Twitter.

What's expected?

Twitter search.

Comment 1

4 years ago
Easy fix imo.

Thunderbird currently uses this URL:
"http://search.twitter.com/search?q=[searchterm]"

Whereas this is the correct one (at least it works for me):
"https://twitter.com/search?q=[searchterm]"

(Notice that Twitter always uses HTTPS since some time.)

Comment 2

4 years ago
Do you want to take on creating a patch?

Comment 3

4 years ago
<http://mxr.mozilla.org/comm-central/search?string=search.twitter.com&filter=^[^\0]*$>
OS: Windows 7 → All
Hardware: x86_64 → All
Whiteboard: [good first bug][mentor=mkmelin][string change only]

Comment 4

4 years ago
Grr, bugzilla autolinks badly. But see the URL field
(Assignee)

Comment 5

4 years ago
Created attachment 752524 [details] [diff] [review]
proposed patch

fix the url and to keep consistent with other engines. i moved the param to element.
Attachment #752524 - Flags: review?(mkmelin+mozilla)
(Assignee)

Updated

4 years ago
Assignee: nobody → ananuti

Comment 6

4 years ago
Comment on attachment 752524 [details] [diff] [review]
proposed patch

Review of attachment 752524 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/locales/en-US/searchplugins/twitter.xml
@@ +6,5 @@
>  <ShortName>Twitter Search</ShortName>
>  <Description>Realtime Twitter Search</Description>
>  <InputEncoding>UTF-8</InputEncoding>
>  <Image width="16" height="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAiklEQVR42mNgGDxgzTsBnOJr3hUAcQMQJyCJCaArXA9XgCp+Hoj/I+H9QHwfUy1EAqRgPtz0Ne8M0DTD8HuwHJoBCWgKQAb14zAgAJtf9+NQjIlxBJYB1GZCBpzHFxMNRBiSgM8AByyhTqTtqF5Zj1UzrrQCTRjz8Th/Pm7NmLY3IGFQ1CowDG8AAK5P9364gzTrAAAAAElFTkSuQmCC</Image>
> +<Url type="text/html" method="get" template="https://twitter.com/search">

please make it uppercase GET while you're at it

@@ +13,1 @@
>  <SearchForm>http://search.twitter.com/</SearchForm>

you forgot to change this

Comment 7

4 years ago
For reference, firefox fixed this in bug 803335.

Comment 8

4 years ago
I wonder if we should be sending a partner param, like firefox http://mxr.mozilla.org/comm-central/source/mozilla/browser/locales/en-US/searchplugins/twitter.xml#14
Flags: needinfo?(squibblyflabbetydoo)
Flags: needinfo?(mbanner)
(In reply to Magnus Melin from comment #8)
> I wonder if we should be sending a partner param, like firefox
> http://mxr.mozilla.org/comm-central/source/mozilla/browser/locales/en-US/
> searchplugins/twitter.xml#14

No we shouldn't do (the arrangements for different apps are typically different and usually require different params if we do have them so typically we shouldn't sync these - any other data is fine).
Flags: needinfo?(squibblyflabbetydoo)
Flags: needinfo?(mbanner)
(Assignee)

Comment 10

4 years ago
Created attachment 753219 [details] [diff] [review]
proposed patch, v2

addressed review comments.
Attachment #752524 - Attachment is obsolete: true
Attachment #752524 - Flags: review?(mkmelin+mozilla)
Attachment #753219 - Flags: review?(mkmelin+mozilla)

Comment 11

4 years ago
Comment on attachment 753219 [details] [diff] [review]
proposed patch, v2

Review of attachment 753219 [details] [diff] [review]:
-----------------------------------------------------------------

Great! Thx for the patch. r=mkmelin
Attachment #753219 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/809ded80b319
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.