Closed Bug 846312 Opened 7 years ago Closed 7 years ago

Twitter OpenSearch appears to be busted


(Thunderbird :: Search, defect)

Not set


(Not tracked)

Thunderbird 24.0


(Reporter: mconley, Assigned: ananuti)




(Whiteboard: [good first bug][mentor=mkmelin][string change only])


(1 file, 1 obsolete file)


1) In some message, select some text, and choose "Search X search for..." to open an OpenSearch tab
2) In the new tab, choose "Twitter"

What happens?

I get a "Sorry, that page doesn't exist!" error from Twitter.

What's expected?

Twitter search.
Easy fix imo.

Thunderbird currently uses this URL:

Whereas this is the correct one (at least it works for me):

(Notice that Twitter always uses HTTPS since some time.)
Do you want to take on creating a patch?
OS: Windows 7 → All
Hardware: x86_64 → All
Whiteboard: [good first bug][mentor=mkmelin][string change only]
Grr, bugzilla autolinks badly. But see the URL field
Attached patch proposed patch (obsolete) — Splinter Review
fix the url and to keep consistent with other engines. i moved the param to element.
Attachment #752524 - Flags: review?(mkmelin+mozilla)
Assignee: nobody → ananuti
Comment on attachment 752524 [details] [diff] [review]
proposed patch

Review of attachment 752524 [details] [diff] [review]:

::: mail/locales/en-US/searchplugins/twitter.xml
@@ +6,5 @@
>  <ShortName>Twitter Search</ShortName>
>  <Description>Realtime Twitter Search</Description>
>  <InputEncoding>UTF-8</InputEncoding>
>  <Image width="16" height="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAiklEQVR42mNgGDxgzTsBnOJr3hUAcQMQJyCJCaArXA9XgCp+Hoj/I+H9QHwfUy1EAqRgPtz0Ne8M0DTD8HuwHJoBCWgKQAb14zAgAJtf9+NQjIlxBJYB1GZCBpzHFxMNRBiSgM8AByyhTqTtqF5Zj1UzrrQCTRjz8Th/Pm7NmLY3IGFQ1CowDG8AAK5P9364gzTrAAAAAElFTkSuQmCC</Image>
> +<Url type="text/html" method="get" template="">

please make it uppercase GET while you're at it

@@ +13,1 @@
>  <SearchForm></SearchForm>

you forgot to change this
For reference, firefox fixed this in bug 803335.
I wonder if we should be sending a partner param, like firefox
Flags: needinfo?(squibblyflabbetydoo)
Flags: needinfo?(mbanner)
(In reply to Magnus Melin from comment #8)
> I wonder if we should be sending a partner param, like firefox
> searchplugins/twitter.xml#14

No we shouldn't do (the arrangements for different apps are typically different and usually require different params if we do have them so typically we shouldn't sync these - any other data is fine).
Flags: needinfo?(squibblyflabbetydoo)
Flags: needinfo?(mbanner)
addressed review comments.
Attachment #752524 - Attachment is obsolete: true
Attachment #752524 - Flags: review?(mkmelin+mozilla)
Attachment #753219 - Flags: review?(mkmelin+mozilla)
Comment on attachment 753219 [details] [diff] [review]
proposed patch, v2

Review of attachment 753219 [details] [diff] [review]:

Great! Thx for the patch. r=mkmelin
Attachment #753219 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.