846331 - Remove UA override for yelp.com

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

Attachment: Patch to remove the yelp.com UA override

In bug 798694 we added an UA override for yelp.com. Yelp now recognizes the B2G UA as mobile. The override can be removed

Comment 1

[[:fabrice] Fabrice Desré]

Comment on attachment 719492 [details] [diff] [review]
Patch to remove the yelp.com UA override

Review of attachment 719492 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 2

[Jason Smith [:jsmith]]

Let's land this. And let's get some approval on this for v1.

Comment 3

[Jason Smith [:jsmith]]

Comment on attachment 719492 [details] [diff] [review]
Patch to remove the yelp.com UA override

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 

Yelp wasn't recognizing our B2G UA, so we were getting served inferior content.

User impact if declined: 

The user will get served Yelp content with Android in the user agent. Haven't dug into this too deeply, but in some cases with sites, this will result in you getting Android-specific advertisements, which in the context of FF OS, makes no sense.

Testing completed: 

Site compatibility testing one in the related bug - bug 799884.

Risk to taking this patch (and alternatives if risky):

Very low risk. This touches our UA override pref list, so this won't touch production logical code at all.

String or UUID changes made by this patch:

None

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

master: e3480fc9adf689e65e2fd2e325364414f1d82a17
v1-train: d7c8663009c4478994c2da1831ea8e303c5dc460