Closed Bug 846360 Opened 7 years ago Closed 7 years ago

error: expected a class or namespace: gfxImageFormat::ImageFormatRGB16_565

Categories

(Core :: General, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: jdm, Assigned: raul.tabacu)

Details

(Whiteboard: [mentor=jdm][lang=c++][good first bug])

Attachments

(1 file, 1 obsolete file)

b56girard@112722
390 nsRefPtr<gfxImageSurface> imageSurface = new gfxImageSurface(data, size, stride, bpp == 2
b56girard@112722
391 ? gfxImageFormat::ImageFormatRGB16_565
b56girard@112722
392 : gfxImageFormat::ImageFormatARGB32);

Easy fix, just strip off the gfxImageFormat:: prefixes.
My mistake, we need to change gfxImageFormat:: to gfxASurface::.
I'm new to firefox development.Could you assign this to me please?
Assignee: nobody → raul.tabacu
That looks right to me. Have you compiled this on OS X?
I do not have acces to OS X.Sorry.
Can you attach your patch to this bug?
Comment on attachment 722407 [details] [diff] [review]
replaced gfxImageFormat with gfxASurface

commit 495ee711dae97ee46174a330d8b01fdef6795070
Author: Raul <keops@Hyperion.(none)>
Date:   Wed Mar 6 10:36:19 2013 +0200

    Bug 846360-namespace modified

diff --git a/gfx/thebes/gfxPlatformMac.cpp b/gfx/thebes/gfxPlatformMac.cpp
index 6c306bb..6e354d4 100644
--- a/gfx/thebes/gfxPlatformMac.cpp
+++ b/gfx/thebes/gfxPlatformMac.cpp
@@ -388,8 +388,8 @@ gfxPlatformMac::CreateThebesSurfaceAliasForDrawTarget_hack(mozilla::gfx::DrawTar
     size_t stride = CGBitmapContextGetBytesPerRow(cg);
     gfxIntSize size(aTarget->GetSize().width, aTarget->GetSize().height);
     nsRefPtr<gfxImageSurface> imageSurface = new gfxImageSurface(data, size, stride, bpp == 2
-                                                                                     ? gfxImageFormat::ImageFormatRGB16_565
-                                                                                     : gfxImageFormat::ImageFormatARGB32);
+                                                                                     ? gfxASurface::ImageFormatRGB16_565
+                                                                                     : gfxASurface::ImageFormatARGB32);
     // Here we should return a gfxQuartzImageSurface but quartz will assumes that image surfaces
     // don't change which wont create a proper alias to the draw target, therefore we have to
     // return a plain image surface.
Was this bug fixed?
Oops, I dropped the ball here.
Attachment #722407 - Flags: review?(jmuizelaar)
Comment on attachment 722407 [details] [diff] [review]
replaced gfxImageFormat with gfxASurface

This does not seem to be a patch
Rahul, would you mind submitting what you posted in comment 9 as the patch here? We work in diffs instead of whole files.
Flags: needinfo?(josh)
Flags: needinfo?(raul.tabacu)
Attachment #722407 - Attachment is obsolete: true
Attachment #722407 - Flags: review?(jmuizelaar)
Flags: needinfo?(raul.tabacu)
Flags: needinfo?(josh)
Comment on attachment 732994 [details] [diff] [review]
replaced gfxImageFormat with gfxASurface

Thanks!
Attachment #732994 - Flags: review?(jmuizelaar)
Attachment #732994 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/35f98c472fb1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.