error: expected a class or namespace: gfxImageFormat::ImageFormatRGB16_565

RESOLVED FIXED in mozilla23

Status

()

Core
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jdm, Assigned: raul.tabacu)

Tracking

unspecified
mozilla23
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=jdm][lang=c++][good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
b56girard@112722
390 nsRefPtr<gfxImageSurface> imageSurface = new gfxImageSurface(data, size, stride, bpp == 2
b56girard@112722
391 ? gfxImageFormat::ImageFormatRGB16_565
b56girard@112722
392 : gfxImageFormat::ImageFormatARGB32);

Easy fix, just strip off the gfxImageFormat:: prefixes.
(Reporter)

Comment 1

4 years ago
http://hg.mozilla.org/mozilla-central/annotate/0a91da5f5eab/gfx/thebes/gfxPlatformMac.cpp#l391
(Reporter)

Comment 2

4 years ago
My mistake, we need to change gfxImageFormat:: to gfxASurface::.
(Assignee)

Comment 3

4 years ago
I'm new to firefox development.Could you assign this to me please?
(Reporter)

Updated

4 years ago
Assignee: nobody → raul.tabacu
(Assignee)

Comment 4

4 years ago
does this solve the problem?
https://github.com/Keops92/mozilla-central/commit/495ee711dae97ee46174a330d8b01fdef6795070
(Reporter)

Comment 5

4 years ago
That looks right to me. Have you compiled this on OS X?
(Assignee)

Comment 6

4 years ago
I do not have acces to OS X.Sorry.
(Reporter)

Comment 7

4 years ago
Can you attach your patch to this bug?
(Assignee)

Comment 8

4 years ago
Created attachment 722407 [details] [diff] [review]
replaced gfxImageFormat with gfxASurface
(Assignee)

Comment 9

4 years ago
Comment on attachment 722407 [details] [diff] [review]
replaced gfxImageFormat with gfxASurface

commit 495ee711dae97ee46174a330d8b01fdef6795070
Author: Raul <keops@Hyperion.(none)>
Date:   Wed Mar 6 10:36:19 2013 +0200

    Bug 846360-namespace modified

diff --git a/gfx/thebes/gfxPlatformMac.cpp b/gfx/thebes/gfxPlatformMac.cpp
index 6c306bb..6e354d4 100644
--- a/gfx/thebes/gfxPlatformMac.cpp
+++ b/gfx/thebes/gfxPlatformMac.cpp
@@ -388,8 +388,8 @@ gfxPlatformMac::CreateThebesSurfaceAliasForDrawTarget_hack(mozilla::gfx::DrawTar
     size_t stride = CGBitmapContextGetBytesPerRow(cg);
     gfxIntSize size(aTarget->GetSize().width, aTarget->GetSize().height);
     nsRefPtr<gfxImageSurface> imageSurface = new gfxImageSurface(data, size, stride, bpp == 2
-                                                                                     ? gfxImageFormat::ImageFormatRGB16_565
-                                                                                     : gfxImageFormat::ImageFormatARGB32);
+                                                                                     ? gfxASurface::ImageFormatRGB16_565
+                                                                                     : gfxASurface::ImageFormatARGB32);
     // Here we should return a gfxQuartzImageSurface but quartz will assumes that image surfaces
     // don't change which wont create a proper alias to the draw target, therefore we have to
     // return a plain image surface.

Comment 10

4 years ago
Was this bug fixed?
(Reporter)

Comment 11

4 years ago
Oops, I dropped the ball here.
(Reporter)

Updated

4 years ago
Attachment #722407 - Flags: review?(jmuizelaar)
Comment on attachment 722407 [details] [diff] [review]
replaced gfxImageFormat with gfxASurface

This does not seem to be a patch
(Reporter)

Comment 13

4 years ago
Rahul, would you mind submitting what you posted in comment 9 as the patch here? We work in diffs instead of whole files.
Flags: needinfo?(josh)
(Reporter)

Updated

4 years ago
Flags: needinfo?(raul.tabacu)
(Assignee)

Comment 14

4 years ago
Created attachment 732994 [details] [diff] [review]
replaced gfxImageFormat with gfxASurface
Attachment #722407 - Attachment is obsolete: true
Attachment #722407 - Flags: review?(jmuizelaar)
Flags: needinfo?(raul.tabacu)
Flags: needinfo?(josh)
(Reporter)

Comment 15

4 years ago
Comment on attachment 732994 [details] [diff] [review]
replaced gfxImageFormat with gfxASurface

Thanks!
Attachment #732994 - Flags: review?(jmuizelaar)
Attachment #732994 - Flags: review?(jmuizelaar) → review+
(Reporter)

Comment 16

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/35f98c472fb1

My apologies for the delay.
https://hg.mozilla.org/mozilla-central/rev/35f98c472fb1
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.