b56girard@112722 390 nsRefPtr<gfxImageSurface> imageSurface = new gfxImageSurface(data, size, stride, bpp == 2 b56girard@112722 391 ? gfxImageFormat::ImageFormatRGB16_565 b56girard@112722 392 : gfxImageFormat::ImageFormatARGB32); Easy fix, just strip off the gfxImageFormat:: prefixes.
My mistake, we need to change gfxImageFormat:: to gfxASurface::.
I'm new to firefox development.Could you assign this to me please?
does this solve the problem? https://github.com/Keops92/mozilla-central/commit/495ee711dae97ee46174a330d8b01fdef6795070
That looks right to me. Have you compiled this on OS X?
I do not have acces to OS X.Sorry.
Can you attach your patch to this bug?
Comment on attachment 722407 [details] [diff] [review] replaced gfxImageFormat with gfxASurface commit 495ee711dae97ee46174a330d8b01fdef6795070 Author: Raul <keops@Hyperion.(none)> Date: Wed Mar 6 10:36:19 2013 +0200 Bug 846360-namespace modified diff --git a/gfx/thebes/gfxPlatformMac.cpp b/gfx/thebes/gfxPlatformMac.cpp index 6c306bb..6e354d4 100644 --- a/gfx/thebes/gfxPlatformMac.cpp +++ b/gfx/thebes/gfxPlatformMac.cpp @@ -388,8 +388,8 @@ gfxPlatformMac::CreateThebesSurfaceAliasForDrawTarget_hack(mozilla::gfx::DrawTar size_t stride = CGBitmapContextGetBytesPerRow(cg); gfxIntSize size(aTarget->GetSize().width, aTarget->GetSize().height); nsRefPtr<gfxImageSurface> imageSurface = new gfxImageSurface(data, size, stride, bpp == 2 - ? gfxImageFormat::ImageFormatRGB16_565 - : gfxImageFormat::ImageFormatARGB32); + ? gfxASurface::ImageFormatRGB16_565 + : gfxASurface::ImageFormatARGB32); // Here we should return a gfxQuartzImageSurface but quartz will assumes that image surfaces // don't change which wont create a proper alias to the draw target, therefore we have to // return a plain image surface.
Was this bug fixed?
Oops, I dropped the ball here.
Comment on attachment 722407 [details] [diff] [review] replaced gfxImageFormat with gfxASurface This does not seem to be a patch
Rahul, would you mind submitting what you posted in comment 9 as the patch here? We work in diffs instead of whole files.
Created attachment 732994 [details] [diff] [review] replaced gfxImageFormat with gfxASurface
Comment on attachment 732994 [details] [diff] [review] replaced gfxImageFormat with gfxASurface Thanks!
https://hg.mozilla.org/integration/mozilla-inbound/rev/35f98c472fb1 My apologies for the delay.