846460 - Build error for failing to clobber after moz-build switchover has two consecutive period characters

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Daniel Holbert [:dholbert]]

I just built after pulling in the moz.build changes, and I got this build error message:
/scratch/work/builds/mozilla-central/mozilla-central.11-08-17.14-31/mozilla/config/rules.mk:26: *** Variable DIRS is defined in Makefile. It should only be defined in moz.build files..  Stop.

We've got a duplicate period after "files" there. Looks like that's because "$(error" invocations in rules.mk aren't supposed to end in a period, but this particular one does.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 719642 [details] [diff] [review]
fix v1

Review of attachment 719642 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't realize make introduced proper punctuation! Oh, make.

r+ is conditional on also copying /config/rules.mk into /js/src/config/rules.mk. If you fail to do this, you'll get another build error in check-sync-dirs.

Comment 3

[Daniel Holbert [:dholbert]]

Ah, good point -- I'll make the same change in js before landing. Thanks!

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/777d41b883a9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/777d41b883a9