846466 - Support for getting user serial support not backwards compatible with older versions of the agent

Status: RESOLVED INCOMPLETE

(Testing :: Mozbase, defect)

Description

[William Lachance (:wlach)]

When I added support for getting the user serial of a process in bug 838844, I neglected to test whether droid.py still worked properly on older versions of the agent. When I updated the code on one of the eideticker machines and tried to use it with the LG-G2X (still using an older version of the agent), I got this error:

  File "/home/mozauto/src/eideticker/src/mozbase/mozdevice/mozdevice/droid.py", line 31, in launchApplication
    acmd = [ "am", "start" ] + self._getExtraAmStartArgs() + \
  File "/home/mozauto/src/eideticker/src/mozbase/mozdevice/mozdevice/droid.py", line 106, in _getExtraAmStartArgs
    if self.userSerial is not None:
AttributeError: 'DroidSUT' object has no attribute 'userSerial'

Easily fixed.

Comment 1

[William Lachance (:wlach)]

Attachment: Quick patch for backwards compatibility with older agents

Comment 2

[William Lachance (:wlach)]

Attachment: Second try at a quick patch

The previous one had some unintended stuff in it

Comment 3

[Geoff Brown [:gbrown]]

Comment on attachment 719649 [details] [diff] [review]
Second try at a quick patch

Review of attachment 719649 [details] [diff] [review]:
-----------------------------------------------------------------

I haven't had cause to use userSerial much, but this LGTM.

Comment 4

[William Lachance (:wlach)]

We don't support the agent anymore.