846494 - [B2G]Localization: Reboot menu screen has overlapping strings and translation problem on multiple languages

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Natalya Kot [:nkot]]

Attachment: Hrvatski

Description:
Reboot menu screen has overlapping strings when switch to different languages, Slovenčina is left untranslated

Repro Steps:
1) Updated to Unagi Build ID: 20130228070201
2) Open Settings app
3) Select Language
4) Select "Hrvatski"
5) Tap OK
6) Longpress power button to bring up reboot menu screen
7) Repeat steps 2-6 for Nederlands, Polski, Русский, and Slovenčina languages

Expected:
- reboot menu options are translated to selected language and look properly

Actual:
- some overlapping strings
- "Slovenčina" screen is not translated, all options shown in English

Repro frequency:
100%

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3867fca22e3d
Gaia: a41c7921fbf0839b894f277261dad4a22507f979

*screenshots attached

Comment 1

[Natalya Kot [:nkot]]

Attachment: Nederlands

Comment 2

[Natalya Kot [:nkot]]

Attachment: Polski

Comment 3

[Natalya Kot [:nkot]]

Attachment: Русский

Comment 4

[Natalya Kot [:nkot]]

Attachment: Slovenčina

Comment 5

[Deepa Subramanian]

The string for "Restart" is overlapping. The screenshot is already attached on comment 1. 

This issue repros when the user sets the language to Nederlands.
Unagi Build ID: 20130605070207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/09dc1ae3b1b5
Gaia: 92a6e36957145cdb2ac8867e5cdba8ecf12308fc

Comment 6

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Asking UX for a possible solution here: should those strings be truncated with ellipsis or split on multiple lines without overlapping?

Comment 8

[Stephany Wilkes]

Assigning to Francis since Rob is out, and the expected behavior for this keeps coming up (note to self to document and share it)!

Comment 9

[Francis Djabri [:djabber]]

I think the best behavior here would be to wrap the text over multiple lines rather than truncating with ellipsis and this is the approach that we've followed elsewhere - e.g., like in the FTE list of cities.

Comment 10

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #10729 - Break overflowing labels on multiple lines

Sleep menu labels that overflow for certain locales are now displayed on multiple lines without overlapping other labels.

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 769955 [details]
Pull Request #10729 - Break overflowing labels on multiple lines

simple css change, r=alive.

Comment 12

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks, Alive!

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/c9beb369584e11e34d562164376036e55eec54f7

Comment 13

[Tim Maks van den Broek [:mad_maks]]

Looking good, build 20130703002432 set to dutch. Thanks

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 c9beb369584e11e34d562164376036e55eec54f7
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 15

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Created a new pull request that fixes the merge conflict: https://github.com/mozilla-b2g/gaia/pull/10850

Alive, can you have a look and uplift to v1-train if everything is good?

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

v1-train
https://github.com/mozilla-b2g/gaia/commit/cd41b9fea83b326128a15f88e7068343ee626a38

Comment 17

[Delphine Lebédel [:delphine - Use needinfo]]

Verified fixed on v1 train, for all shipping locales
(July 9th build, Moz Ril, Leo phone)

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: cd41b9fea83b326128a15f88e7068343ee626a38
v1.1.0hd: b73696f0548b30b6c0ec94b314c2c313f4f23ef6