The default bug view has changed. See this FAQ.

The unread count on the chat toolbar button is ugly and unreadable on a Mac retina screen

RESOLVED FIXED in Thunderbird 23.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: florian, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 23.0
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Reporter)

Description

4 years ago
Created attachment 719726 [details]
Screenshot of the chat toolbarbutton

See attached screenshot.

I'm not completely sure if the red circle is too large or the font size too small (or even both):
- I think the circle is too big because I think I'm supposed to still be able to see the icon
- I also think the font size is too small because the number is completely unreadable at such a small size (it's half the size in both width and height when actually displayed on the retina screen).
(Assignee)

Comment 1

4 years ago
Created attachment 720310 [details] [diff] [review]
proposed fix

The badge is also on LoDPI to big. I've tweaked some values to let the badge be always 11px * 11px. Under OSX I made the font 0.7em instead of 0.6em.

Florian, I gave you f? to check how it looks under HiDPI.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #720310 - Flags: review?(mconley)
Attachment #720310 - Flags: feedback?(florian)
Created attachment 728606 [details]
Screenshot of the chat toolbarbutton on Windows XP

This problem isn't limited to Macs either. The look on Windows (XP), shame on me;) is terrible too! See the Windows screenshot.
Paenglab - can you please post screenshots of the badges for each platform?
Flags: needinfo?(richard.marti)
Attachment #720310 - Flags: ui-review?(mconley)
(Assignee)

Comment 4

4 years ago
Created attachment 729139 [details] [diff] [review]
patch v2

I saw on various Linux with different font height also different badge height because of the setting of 0.6em (it varied on the different platforms between 7.2px and 7.8px). I set now a fixed height of 8px. The other changes are needed to be correct with the fixed height.
Attachment #720310 - Attachment is obsolete: true
Attachment #720310 - Flags: ui-review?(mconley)
Attachment #720310 - Flags: review?(mconley)
Attachment #720310 - Flags: feedback?(florian)
Attachment #729139 - Flags: ui-review?(mconley)
Attachment #729139 - Flags: review?(mconley)
Flags: needinfo?(richard.marti)
(Assignee)

Comment 5

4 years ago
Created attachment 729142 [details]
screenshot with latest patch applied
(Assignee)

Comment 6

4 years ago
Created attachment 729773 [details] [diff] [review]
patch v2 unbitrotted

Patch unbitrotted after landing of Bug 844599.
Attachment #729139 - Attachment is obsolete: true
Attachment #729139 - Flags: ui-review?(mconley)
Attachment #729139 - Flags: review?(mconley)
Attachment #729773 - Flags: ui-review?(mconley)
Attachment #729773 - Flags: review?(mconley)
Comment on attachment 729773 [details] [diff] [review]
patch v2 unbitrotted

Review of attachment 729773 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, I think this looks far far better. Thank you, Richard!
Attachment #729773 - Flags: ui-review?(mconley)
Attachment #729773 - Flags: ui-review+
Attachment #729773 - Flags: review?(mconley)
Attachment #729773 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/f601c38e6fe7
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in before you can comment on or make changes to this bug.