9.43 KB, image/png
4.66 KB, image/png
8.76 KB, image/png
3.71 KB, patch
|Details | Diff | Splinter Review|
Created attachment 719726 [details] Screenshot of the chat toolbarbutton See attached screenshot. I'm not completely sure if the red circle is too large or the font size too small (or even both): - I think the circle is too big because I think I'm supposed to still be able to see the icon - I also think the font size is too small because the number is completely unreadable at such a small size (it's half the size in both width and height when actually displayed on the retina screen).
Created attachment 720310 [details] [diff] [review] proposed fix The badge is also on LoDPI to big. I've tweaked some values to let the badge be always 11px * 11px. Under OSX I made the font 0.7em instead of 0.6em. Florian, I gave you f? to check how it looks under HiDPI.
Created attachment 728606 [details] Screenshot of the chat toolbarbutton on Windows XP This problem isn't limited to Macs either. The look on Windows (XP), shame on me;) is terrible too! See the Windows screenshot.
Paenglab - can you please post screenshots of the badges for each platform?
Created attachment 729139 [details] [diff] [review] patch v2 I saw on various Linux with different font height also different badge height because of the setting of 0.6em (it varied on the different platforms between 7.2px and 7.8px). I set now a fixed height of 8px. The other changes are needed to be correct with the fixed height.
Attachment #720310 - Attachment is obsolete: true
Attachment #720310 - Flags: review?(mconley)
Attachment #720310 - Flags: feedback?(florian)
Attachment #729139 - Flags: ui-review?(mconley)
Attachment #729139 - Flags: review?(mconley)
Created attachment 729773 [details] [diff] [review] patch v2 unbitrotted Patch unbitrotted after landing of Bug 844599.
Comment on attachment 729773 [details] [diff] [review] patch v2 unbitrotted Review of attachment 729773 [details] [diff] [review]: ----------------------------------------------------------------- Yes, I think this looks far far better. Thank you, Richard!
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in before you can comment on or make changes to this bug.