Closed
Bug 846553
Opened 11 years ago
Closed 11 years ago
Change SCTP connection to non-blocking so we don't need a temporary thread
Categories
(Core :: WebRTC: Networking, defect)
Core
WebRTC: Networking
Tracking
()
VERIFIED
FIXED
mozilla22
People
(Reporter: jesup, Assigned: jesup)
References
Details
(Whiteboard: [WebRTC], [blocking-webrtc+])
Attachments
(1 file, 1 obsolete file)
9.92 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
Should also avoid the possibility of the thread being leaked on shutdown.
Assignee | ||
Comment 1•11 years ago
|
||
WIP patch, some error checks still needed
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 719731 [details] [diff] [review] Use non-blocking connect() for SCTP DataChannelConnections Need to check error from usrsctp_connect() when it fails (real failure, or normal non-binding result) and we never have hooked up the association lost to onConnectionClosed
Attachment #719731 -
Flags: feedback?(tuexen)
Attachment #719731 -
Flags: feedback?(mcmanus)
Comment 3•11 years ago
|
||
The patch makes sense. Error checking should be added.
Comment 4•11 years ago
|
||
Comment on attachment 719731 [details] [diff] [review] Use non-blocking connect() for SCTP DataChannelConnections Review of attachment 719731 [details] [diff] [review]: ----------------------------------------------------------------- i definitely support this over more threading :)
Attachment #719731 -
Flags: feedback?(mcmanus) → feedback+
Assignee | ||
Updated•11 years ago
|
Whiteboard: [WebRTC], [blocking-webrtc-] → [WebRTC], [blocking-webrtc+]
Assignee | ||
Comment 6•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #719731 -
Attachment is obsolete: true
Attachment #719731 -
Flags: feedback?(tuexen)
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 721131 [details] [diff] [review] Use non-blocking connect() for SCTP DataChannelConnections, notify disonnects Largely unchanged other than checking EINPROGRESS after usrsctp_connect(), removing the last vestige of the connect thread, and added never-implemented application notification of association loss/close.
Attachment #721131 -
Flags: review?(mcmanus)
Comment 8•11 years ago
|
||
Comment on attachment 721131 [details] [diff] [review] Use non-blocking connect() for SCTP DataChannelConnections, notify disonnects Review of attachment 721131 [details] [diff] [review]: ----------------------------------------------------------------- good to see that thread go away ::: netwerk/sctp/datachannel/DataChannel.cpp @@ +316,5 @@ > + // Make non-blocking for bind/connect. SCTP over UDP defaults to non-blocking > + // in associations for normal IO > + if (usrsctp_set_non_blocking(mMasterSocket, 1) < 0) { > + LOG(("Couldn't set non_blocking on SCTP socket")); > + } shouldn't this be a fatal error now?
Attachment #721131 -
Flags: review?(mcmanus) → review+
Assignee | ||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e90c06c27bca
Target Milestone: --- → mozilla22
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e90c06c27bca
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 11•11 years ago
|
||
Verified using STR in the dupe.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in
before you can comment on or make changes to this bug.
Description
•