There's a "variable is used uninitialized whenever switch default is taken" warning in nsImageMap.cpp that we should fix.
Comment on attachment 719735 [details] [diff] [review] patch Per bug 846552 comment 2, MOZ_NOT_REACHED is probably not what we want here. I'd rather we keep the NS_NOTREACHED (or change it to MOZ_ASSERT(false, ...) if you like), and just replace break with "return NS_ERROR_FAILURE")
While you're here, too, we can drop the "if (!area)" check, at the end of the patch's context, since with the early-return I'm suggesting plus infallible-malloc, area will be guaranteed to be non-null there.
Attachment #719735 - Flags: review?(dholbert) → review-
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 873346
You need to log in before you can comment on or make changes to this bug.