846563 - [B2G][SIM Security] Launching the Contacts app while the SIM is locked does not bring up the SIM PIN entry page

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Chris Kreinbring [:CKreinbring]]

Unagi build: 20130225070200

Prerequisite: SIM PIN is enabled and the device has just been rebooted.

Steps to reproduce:
1. Unlock the lock screen, entering the unlock code if necessary.
2. At the SIM PIN entry page, tap the X in the upper left corner to exit the page.
3. Tap the Contact icon to launch the app.
4. Observe the page that loads.

Expected:
The SIM PIN entry page appears, prompting the user to enter the code.

Actual:
The Contacts page launches.

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3a5a27992a75
Gaia: 5691a16fff8e1403c75ed9d6f3a443b7e58198c6
Kernel Date: Dec 5
Test Suite: SIM Security
UCID: set-207
https://moztrap.mozilla.org/runtests/run/859/env/305/?pagenumber=1&pagesize=50&sortfield=order&sortdirection=asc&filter-id=4529&filter-suite=157

Comment 1

[Nick Davidson]

in reference to Description

Test Case # 4529
UCID: set-207

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=4529

Comment 2

[Chris Kreinbring [:CKreinbring]]

Still repros in Unagi version 20130318070202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/af9270e8f205
Gaia: a78ebf426840b5ef08c0cc3e437ad30aba3e2528
Kernel Date: Dec 5

Comment 3

[Peter Dolanjski [:pdol]]

Josh/Casey, was the original plan to prompt for SIM PIN on contacts entry (if the user cancelled the entry on unlock)?  Or was this prompt limited to certain apps (dialer/messaging)?

Comment 4

[Casey Yee]

The contacts app does not access the SIM card during any normal operation.  Because of this I don't think it makes sense to lock the user out of the contacts app when SIM Pin is active.  

The only time contacts are read from the SIM is during SIM contact import.  It would make sense in the import case that the user would be prompted for the PIN if not already entered.

Cc. Ayman for further comment.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Why we need to ask for the sim pin when launching contacts?

Actually, IMHO, this is contraproducent for the user. So far the only operations that we do with the sim card in contacts are regarding if we can import the sim contacts to the phone, and if we don't introduce the sim pin we won't be able to perform this operation.

Cheers,
F.

Comment 6

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

It turns out this bug was caused by a regression, and my patch for Bug 835972 fixes the behavior.

https://github.com/mozilla-b2g/gaia/commit/b126eeb39ed9bfa1e5662386f74611d5d6527b18

The reasoning behind showing the SIM PIN dialog (if the user cancels it after the unlock screen) was that applications which require a mobile connection (SMS; Communications -- which includes Dialer, Contacts; and Settings) need to notify the user about the SIM being locked.

Comment 7

[Chris Kreinbring [:CKreinbring]]

Fix verified on Leo 1.1 commercial RIL

Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1
RIL Version: 01.01.00.019.164