846574 - [B2G][SIM Security] Launching the Settings app while the SIM is locked does not bring up the SIM PIN entry page

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Chris Kreinbring [:CKreinbring]]

Unagi build: 20130225070200

Prerequisite: SIM PIN is enabled and the device has just been rebooted.

Steps to reproduce:
1. Unlock the lock screen, entering the unlock code if necessary.
2. At the SIM PIN entry page, tap the X in the upper left corner to exit the page.
3. Tap the Settings icon to launch the app.
4. Observe the page that loads.

Expected:
The SIM PIN entry page appears, prompting the user to enter the code.

Actual:
The Settings page launches.

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3a5a27992a75
Gaia: 5691a16fff8e1403c75ed9d6f3a443b7e58198c6
Kernel Date: Dec 5
Test Suite: SIM Security
UCID: set-207
https://moztrap.mozilla.org/runtests/run/859/env/305/?pagenumber=1&pagesize=50&sortfield=order&sortdirection=asc&filter-id=4531&filter-suite=157

Comment 1

[Nick Davidson]

in reference to main description

Test Case # 4531 
UCID: set-207

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=4531

Comment 2

[John Hammink]

set-207 "As a user I want the phone to display "SIM Locked" dialog box when the user cancels out of the SIM PIN entry process and accesses SIM capabilities such as Dialer/Messaging so that I know I must "Unlock the SIM to access the cellular data network".  Does this testcase match the requirement?

Comment 3

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Screenshot Settings App showing SIM card locked msg

The Settings App shows the message "The SIM card is locked." under Call Settings and Cellular & Data, thus informing the user about the SIM card state (see screenshot) -- a SIM PIN prompt in this case would just annoy the user, if it's purpose is to remind him that the SIM card is locked. 

Wouldn't it make more sense to not show the prompt at all if such info is already provided to the user?

Comment 4

[Peter Dolanjski [:pdol]]

Josh/Casey, was the original plan to prompt for SIM PIN on settings entry (if the user cancelled the entry on unlock)?  Or was this prompt limited to certain apps (dialer/messaging)?

Comment 5

[Casey Yee]

The way it is currently implemented is correct.   

As already mentioned in Comment 3, we appropriately show the user "The SIM card is locked" under Call settings and Cellular & Data.

We also shouldn't be locking the user out of settings that are non-SIM related.

Comment 6

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

It turns out this bug was caused by a regression, and my patch for Bug 835972 fixes the behavior.

https://github.com/mozilla-b2g/gaia/commit/b126eeb39ed9bfa1e5662386f74611d5d6527b18

The way this was initially implemented was to display the SIM PIN dialog for the Settings app since the app has 'telephony' permission -- applications which require a mobile connection (SMS; Communications -- which includes Dialer, Contacts; and Settings) notify the user about the SIM being locked by showing the SIM PIN dialog.

Casey/Josh, should I file a follow-up bug and deactivate the SIM PIN dialog for the Settings App?

Comment 7

[Josh Carpenter [:jcarpenter]]

Deferring to Casey on this one.

Comment 8

[Casey Yee]

(In reply to Mihai Cirlanaru [:mcirlanaru] from comment #6)
> The way this was initially implemented was to display the SIM PIN dialog for
> the Settings app since the app has 'telephony' permission

As per comment 5, we should not be presenting SIM pin entry when opening settings app.  

> -- applications
> which require a mobile connection (SMS; Communications -- which includes
> Dialer, Contacts; and Settings) notify the user about the SIM being locked
> by showing the SIM PIN dialog.

Cases for specific application are not part of this bug and should be filed separately.

Comment 9

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

I am marking this as fixed as detailed in comment 6 and opening a new bug to highlight that the correct behavior should be to not present the SIM PIN dialog for the settings app, as Casey mentioned in comment 8.

The testcase referenced in comment 1 should be updated accordingly.

Comment 10

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Filed bug 861206 to follow-up on the intended behavior of the SIM PIN dialog.

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

blocking so we can get this regression fix uplifted.

Comment 12

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Uplifted to v1-train: 30620a3a7aff89b603a73a0265b668479955aa50 from Bug 835972 patch

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Mihai Cirlanaru [:mcirlanaru] from comment #12)
> Uplifted to v1-train: 30620a3a7aff89b603a73a0265b668479955aa50 from Bug
> 835972 patch

Please set the status-b2g18 flag when you land on v1-train

Comment 14

[John Hammink]

As this is now correct, I'll refer to the more recent bug.  Also it's added to moztrap so we'll catch any regressions that way.

Comment 15

[Chris Kreinbring [:CKreinbring]]

Verifying fixed on Leo 1.1 commercial RIL per comment 6 and comment 9.

Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1
RIL Version: 01.01.00.019.164