846575 - Create a convenience member of ReflowConfig for isBalancing

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Scott Johnson (:jwir3)]

Currently, to check if we're balancing columns in nsColumnSetFrame, we use a comparison of ColumnBalanceData.mBalanceColCount to INT32_MAX. Instead of doing this everywhere, we should add a convenience function, IsBalancing() to ColumnBalanceData, to help clean up the code and make it a bit more readable.

Comment 1

[Scott Johnson (:jwir3)]

Attachment: b846575

Also pushed to try:

https://tbpl.mozilla.org/?tree=Try&rev=53dc72d8c5a4

Comment 2

[fantasai]

Comment on attachment 721881 [details] [diff] [review]
b846575

+  ReflowConfig config = { numColumns, colWidth, expectedWidthLeftOver, colGap,
+                          colHeight, numColumns < INT32_MAX };

Any reason "numColumns < INT32_MAX" isn't just "isBalancing"?

Comment 3

[Scott Johnson (:jwir3)]

(In reply to fantasai from comment #2)
> Any reason "numColumns < INT32_MAX" isn't just "isBalancing"?

Nope, other than I wrote that first then refactored the rest of the function, and promptly forgot. ;) I've changed it, and I'll push it to inbound as soon as inbound opens back up.

Comment 4

[Scott Johnson (:jwir3)]

Inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/31823d274fd1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/31823d274fd1