84664 - Double-clicking mozilla.exe should open new window

Status: VERIFIED FIXED

(Core :: XUL, defect, P2)

Description

[mdeslaur]

With mozilla already open, double-clicking mozilla.exe a second time should pop
up a new browser window. This was working in 0.9, but not in 0.9.1.

Comment 1

[timeless]

reporter are you using -turbo?

Comment 2

[Bill Law]

I "broke" this with recent DDE changes.  It is easy to distinguish the requests
that must go to an already-open window versus ones that ought not.  I'm
nominating this for RTM.

Comment 3

[timeless]

ok

Comment 4

[Paul Chen]

nav triage team:

Gotta fix this. Bill, can you get to this before you go on vacation?
Marking p2, mozilla0.9.2

Comment 5

[Paul Chen]

nav triage team:

Forgot to add nsbeta1+

Comment 6

[Paul Chen]

*** Bug 50424 has been marked as a duplicate of this bug. ***

Comment 7

[Bill Law]

Yes, I'll fix this ASAP (today or tomorrow).

Comment 8

[Bill Law]

Attachment: Patch to add "newWindow" flag as argument to HandleRequest and OpenBrowserWindow functions

Comment 9

[Bill Law]

I added a PRBool "newWindow" flag to to implementation methods within 
nsNativeAppSupportWin.cpp.  "newWindow" is always PR_TRUE *except* for requests 
that come in via XTYP_REQUEST WWW_OpenURL DDE requests.  So, we always will 
open a new browser window except in cases where the request comes via that 
route (e.g., Adobe Acrobat or other DDE clients).

Comment 10

[Brian Haskin (Janzert)]

*** Bug 85407 has been marked as a duplicate of this bug. ***

Comment 11

[Gilles Durys]

*** Bug 85615 has been marked as a duplicate of this bug. ***

Comment 12

[Blake Ross]

Nit:

+        // If caller requires a new window, then don't use an existing one.
+        if ( newWindow ) {
+            break;
+        }
         if ( !med ) {
             break;
         }

Consolidate these? Either way, sr=blake 

Comment 13

[Bill Law]

Yeah, I debated that.  My conclusion is that the compiler will do the re-write
and to leave it as a separate check more accurately reflects the evolution of
the code.  It matches the rest of that do{}while block as a separate check, too.
 So I think I'll leave it that way, at least until the next time it has to be
tweaked.

Comment 14

[Viswanath Ramachandran]

adding Samir for r=. 

Comment 15

[Samir Gehani]

r=sgehani

Comment 16

[Viswanath Ramachandran]

--> morse

Comment 17

[Stephen P. Morse]

Patch has suffered some bitrot, although it was created only seven days ago!

Attaching identical patch but without the bitrot.

Comment 18

[Stephen P. Morse]

Attachment: same patch but without bitrot

Comment 19

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 20

[Stephen P. Morse]

Oops, forgot to mark this as fixed.  The fix was checked in last night, just 
before the freeze.

Comment 21

[Matthias Versen [:Matti]]

*** Bug 87106 has been marked as a duplicate of this bug. ***

Comment 22

[Chad Austin]

verified win2k 2001062708