846714 - [es-ES] Don't hardcode mobile site for wikipedia-es-ES for Fennec Spanish (Spain) and remove not needed search plugins

Status: VERIFIED FIXED

(Mozilla Localizations :: es-ES / Spanish, defect)

Description

[Axel Hecht [:Pike]]

In bug 825821, we stopped hard-coding the mobile site in the wikipedia plugin, so that wp can work it's magic on whether it should show you the mobile or the desktop site.

Mind porting that change over to your localization? Milos might be able to help. We'll want a patch for the change, and get Milos to review it, or he'll just write the patch himself.

I'm filing this independent of whether we're shipping Fennec, or are close doing so.

Comment 1

[RickieES aka Ricardo Palomares]

It seems we have a bit of a mess in the mobile/searchplugins directory. Guillermo, we should remove wikipedia.xml and yahoo.xml (as we're not using them in list.txt), and make sure that wikipedia-es.xml has the minimal changes to wikipedia.xml from en-US.

Pike, milos, can we do all of the above and the main purpose of this bug in just one patch? Should we provide two consecutive patches? Or even open a separate bug for the cleanup and make it block this bug?

Comment 2

[Axel Hecht [:Pike]]

Sure, one patch is good enough.

Comment 3

[RickieES aka Ricardo Palomares]

Attachment: Patch removing extra files and fixing URL in wikipedia-es.xml

Patch to fix URL in wikipedia-es.xml and removing extra, unneeded files in searchplugins.

This patch has been made on L10n-Beta repository, as the patch should make the trip backwards towards central.

Guillermo, as you're mobile owner, please take a look to the patch and comment here if you find something odd.

Comment 4

[Guillermo López :willyaranda (probably SLOW response)]

Comment on attachment 721916 [details] [diff] [review]
Patch removing extra files and fixing URL in wikipedia-es.xml

Review of attachment 721916 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[RickieES aka Ricardo Palomares]

(In reply to Ricardo Palomares from comment #3)
> Created attachment 721916 [details] [diff] [review]
> Patch removing extra files and fixing URL in wikipedia-es.xml
> 
> Patch to fix URL in wikipedia-es.xml and removing extra, unneeded files in
> searchplugins.
> 
> This patch has been made on L10n-Beta repository, as the patch should make
> the trip backwards towards central.
> 
> Guillermo, as you're mobile owner, please take a look to the patch and
> comment here if you find something odd.

Ping Milos, it's been two weeks since I uploaded the patch for review and we're just one week off to miss this for next release. If you could take a look to this, it would be great. Thanks! :-)

Comment 6

[Milos Dinic [:Milos]]

Comment on attachment 721916 [details] [diff] [review]
Patch removing extra files and fixing URL in wikipedia-es.xml

Review of attachment 721916 [details] [diff] [review]:
-----------------------------------------------------------------

r+, even though you're making changes that this bug wasn't initialy filed for. Please wait for Axel's positive feedback and then push upstream with appropriate commit message, ie. mentioning this bug and our reviews.

Comment 7

[RickieES aka Ricardo Palomares]

(In reply to Milos Dinic [:Milos] from comment #6)
> Comment on attachment 721916 [details] [diff] [review]
> Patch removing extra files and fixing URL in wikipedia-es.xml
> 
> Review of attachment 721916 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r+, even though you're making changes that this bug wasn't initialy filed
> for. Please wait for Axel's positive feedback and then push upstream with
> appropriate commit message, ie. mentioning this bug and our reviews.


Is not comment #2 from Axel enough?

Comment 8

[Milos Dinic [:Milos]]

Axel just said we don't need multiple patches, and "feedback" I meant is another review of code changes quality.

Comment 9

[RickieES aka Ricardo Palomares]

(In reply to Milos Dinic [:Milos] from comment #8)
> Axel just said we don't need multiple patches, and "feedback" I meant is
> another review of code changes quality.


Ping Axel, I know you're surely very busy, but we've missed a cycle and it would be great if this bug doesn't get stalled.

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 721916 [details] [diff] [review]
Patch removing extra files and fixing URL in wikipedia-es.xml

Review of attachment 721916 [details] [diff] [review]:
-----------------------------------------------------------------

r- from my side, redirects are expensive on mobile. Please use the localized name for Special:Search, Especial:Buscar

Comment 11

[RickieES aka Ricardo Palomares]

Attachment: Revised patch with a SearchForm URL that does not trigger redirects

Sorry, didn't notice the redirection. Hope this works.

Comment 12

[RickieES aka Ricardo Palomares]

(In reply to Ricardo Palomares from comment #11)
> Created attachment 738176 [details] [diff] [review]
> Revised patch with a SearchForm URL that does not trigger redirects
> 
> Sorry, didn't notice the redirection. Hope this works.

Uploaded in l10n-mozilla-beta:

http://hg.mozilla.org/releases/l10n/mozilla-beta/es-ES/rev/8cbcc73ebd8d

I've been reading about hg transplant and hg graft, but I'd say it is not intended for moving changeset through different repositories. Any problem if I simply manually apply the same patch in aurora and central?

TIA

Comment 13

[RickieES aka Ricardo Palomares]

(In reply to Ricardo Palomares from comment #12)
> (In reply to Ricardo Palomares from comment #11)
> > Created attachment 738176 [details] [diff] [review]
> > Revised patch with a SearchForm URL that does not trigger redirects
> > 
> > Sorry, didn't notice the redirection. Hope this works.
> 
> Uploaded in l10n-mozilla-beta:
> 
> http://hg.mozilla.org/releases/l10n/mozilla-beta/es-ES/rev/8cbcc73ebd8d
> 
> I've been reading about hg transplant and hg graft, but I'd say it is not
> intended for moving changeset through different repositories. Any problem if
> I simply manually apply the same patch in aurora and central?


Since I got no answer here, I've decided to apply the patch in Aurora and Central. I've done it already for Aurora:

http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-ES/rev/2225e8d77a00

but, when I've tried to do the same in Central, the removals of wikipedia.xml and yahoo.xml have failed. The change in wikipedia-es.xml, however, has been applied cleanly. Can I commit this, or should I prepare a patch with just that change and ask for approval again?

TIA

Comment 14

[RickieES aka Ricardo Palomares]

Sign-offs done for Beta and Aurora, still waiting for an answer on my question in comment #13.

Comment 15

[Axel Hecht [:Pike]]

The removals fail because they're already removed, right?

No further review needed on that.

Comment 16

[RickieES aka Ricardo Palomares]

(In reply to Axel Hecht [:Pike] from comment #15)
> The removals fail because they're already removed, right?
> 
> No further review needed on that.


I wasn't clear enough, sorry. Yes, it fails because the files didn't exist in central. After my last comment, I concluded that Guillermo removed the files in Central long ago, but he forgot to mimic the change in Aurora. Since the locale searchplugins directory does not have to mimic the en-US in number and name of files in it, the L10n dashboard does not warn about such differences and nobody noticed.

Applied on Central:

http://hg.mozilla.org/l10n-central/es-ES/rev/53be618fae88

Comment 17

[RickieES aka Ricardo Palomares]

Already verified in Aurora, so marking fixed.