846715 - [fi] Don't hardcode mobile site for wikipedia-fi for Fennec Finnish

Status: RESOLVED FIXED

(Mozilla Localizations :: fi / Finnish, defect)

Description

[Axel Hecht [:Pike]]

In bug 825821, we stopped hard-coding the mobile site in the wikipedia plugin, so that wp can work it's magic on whether it should show you the mobile or the desktop site.

Mind porting that change over to your localization? Milos might be able to help. We'll want a patch for the change, and get Milos to review it, or he'll just write the patch himself.

I'm filing this independent of whether we're shipping Fennec, or are close doing so.

Comment 1

[Ville Pohjanheimo (inactive)]

Attachment: Remove mobile hardcoding from wikipedia FI searchplugin

Attached is a patch to fix this for Finnish locale.

Comment 2

[Milos Dinic [:Milos]]

Comment on attachment 729162 [details] [diff] [review]
Remove mobile hardcoding from wikipedia FI searchplugin

Review of attachment 729162 [details] [diff] [review]:
-----------------------------------------------------------------

r+. Please wait for Axel's positive feedback and then push upstream with appropriate commit message, ie. mentioning this bug and our reviews.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 729162 [details] [diff] [review]
Remove mobile hardcoding from wikipedia FI searchplugin

Review of attachment 729162 [details] [diff] [review]:
-----------------------------------------------------------------

Please use the localized, name for Special:Search.

::: mobile/searchplugins/wikipedia-fi.xml
@@ +9,5 @@
>  <Url type="application/x-suggestions+json" method="GET" template="http://fi.wikipedia.org/w/api.php">
>      <Param name="action" value="opensearch"/>
>      <Param name="search" value="{searchTerms}"/>
>  </Url>
> +<Url type="text/html" method="GET" template="http://fi.wikipedia.org/wiki/Special:Search">

For mobile, redirects are expensive, thus it's better to use the localized name for Special:Search right away, Toiminnot:Haku.

Comment 4

[Ville Pohjanheimo (inactive)]

Attachment: Remove mobile hardcoding from wikipedia FI searchplugin v2

Thanks Axel. Here's a new version using localized search page / URL.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 738653 [details] [diff] [review]
Remove mobile hardcoding from wikipedia FI searchplugin v2

Review of attachment 738653 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, please commit this patch with a checkin message referencing this bug and my review. Thanks.

Comment 6

[Ville Pohjanheimo (inactive)]

Please advice on how to proceed or close bug. 

Patch was committed ages ago, but I mistakenly did not make a proper commit message.
Current state of wikipedia plugin: http://hg.mozilla.org/releases/l10n/mozilla-aurora/fi/file/5f112f6ccca4/mobile/searchplugins/wikipedia-fi.xml

Comment 7

[Francesco Lodolo [:flod]]

There's a reference to this bug, so it's enough (just missing the review bit).
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fi/rev/c73c849f097f