846721 - [ja] Don't hardcode mobile site for wikipedia-ja for Fennec Japanese

Status: RESOLVED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[Axel Hecht [:Pike]]

In bug 825821, we stopped hard-coding the mobile site in the wikipedia plugin, so that wp can work it's magic on whether it should show you the mobile or the desktop site.

Mind porting that change over to your localization? Milos might be able to help. We'll want a patch for the change, and get Milos to review it, or he'll just write the patch himself.

I'm filing this independent of whether we're shipping Fennec, or are close doing so.

Comment 1

[Masahiko Imanaka [:marsf]]

Attachment: wikipedia-ja update

Comment 2

[Masahiko Imanaka [:marsf]]

Milos:
Could you please review this?

Comment 3

[Milos Dinic [:Milos]]

Comment on attachment 723810 [details] [diff] [review]
wikipedia-ja update

r+. Please wait for Axel's feedback and then commit.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 723810 [details] [diff] [review]
wikipedia-ja update

Review of attachment 723810 [details] [diff] [review]:
-----------------------------------------------------------------

actually, let me take that back real quick. sorry.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 723810 [details] [diff] [review]
wikipedia-ja update

Review of attachment 723810 [details] [diff] [review]:
-----------------------------------------------------------------

r- from my side, redirects are expensive on mobile. Please use the localized name for Special:Search, 特別:検索

Comment 6

[Masahiko Imanaka [:marsf]]

Attachment: wikipedia-ja update2

Changed the URL to avoid redirect.

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 738484 [details] [diff] [review]
wikipedia-ja update2

Review of attachment 738484 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with one nit, please use the human-readable version of 特別:検索 instead of %E7%89%B9%E5%88%A5:%E6%A4%9C%E7%B4%A2 in both places.

Please fix that locally, and then commit with a bug comment referencing this bug and my review.

Comment 8

[Masahiko Imanaka [:marsf]]

Commited to aurora with the fix.

http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/e10cb81f820e
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/3514aee71d15

Can I land them to beta, too?

Comment 9

[Masahiko Imanaka [:marsf]]

Fixed on beta.

http://hg.mozilla.org/releases/l10n/mozilla-beta/ja/rev/37de0e5c03d0
http://hg.mozilla.org/releases/l10n/mozilla-beta/ja-JP-mac/rev/f360e55de150