Closed Bug 846721 Opened 8 years ago Closed 7 years ago

[ja] Don't hardcode mobile site for wikipedia-ja for Fennec Japanese

Categories

(Mozilla Localizations :: ja / Japanese, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Unassigned)

References

Details

(Keywords: productization)

Attachments

(1 file, 1 obsolete file)

In bug 825821, we stopped hard-coding the mobile site in the wikipedia plugin, so that wp can work it's magic on whether it should show you the mobile or the desktop site.

Mind porting that change over to your localization? Milos might be able to help. We'll want a patch for the change, and get Milos to review it, or he'll just write the patch himself.

I'm filing this independent of whether we're shipping Fennec, or are close doing so.
Attached patch wikipedia-ja update (obsolete) — Splinter Review
Attachment #723810 - Flags: review?(milos)
Milos:
Could you please review this?
Comment on attachment 723810 [details] [diff] [review]
wikipedia-ja update

r+. Please wait for Axel's feedback and then commit.
Attachment #723810 - Flags: review?(milos)
Attachment #723810 - Flags: review+
Attachment #723810 - Flags: feedback?(l10n)
Attachment #723810 - Flags: feedback?(l10n) → feedback+
Comment on attachment 723810 [details] [diff] [review]
wikipedia-ja update

Review of attachment 723810 [details] [diff] [review]:
-----------------------------------------------------------------

actually, let me take that back real quick. sorry.
Attachment #723810 - Flags: feedback+ → feedback?(l10n)
Comment on attachment 723810 [details] [diff] [review]
wikipedia-ja update

Review of attachment 723810 [details] [diff] [review]:
-----------------------------------------------------------------

r- from my side, redirects are expensive on mobile. Please use the localized name for Special:Search, 特別:検索
Attachment #723810 - Flags: feedback?(l10n) → feedback-
Changed the URL to avoid redirect.
Attachment #723810 - Attachment is obsolete: true
Attachment #738484 - Flags: review?(l10n)
Comment on attachment 738484 [details] [diff] [review]
wikipedia-ja update2

Review of attachment 738484 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with one nit, please use the human-readable version of 特別:検索 instead of %E7%89%B9%E5%88%A5:%E6%A4%9C%E7%B4%A2 in both places.

Please fix that locally, and then commit with a bug comment referencing this bug and my review.
Attachment #738484 - Flags: review?(l10n) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.