846725 - [ru] Don't hardcode mobile site for wikipedia-ru for Fennec Russian

Status: RESOLVED FIXED

(Mozilla Localizations :: ru / Russian, defect)

Description

[Axel Hecht [:Pike]]

In bug 825821, we stopped hard-coding the mobile site in the wikipedia plugin, so that wp can work it's magic on whether it should show you the mobile or the desktop site.

Mind porting that change over to your localization? Milos might be able to help. We'll want a patch for the change, and get Milos to review it, or he'll just write the patch himself.

I'm filing this independent of whether we're shipping Fennec, or are close doing so.

Comment 1

[Alexander L. Slovesnik]

Attachment: Patch v 1.0

Comment 2

[Milos Dinic [:Milos]]

Comment on attachment 719998 [details] [diff] [review]
Patch v 1.0

Review of attachment 719998 [details] [diff] [review]:
-----------------------------------------------------------------

Alexander, can we please try to avoid redirects and use just "http://ru.wikipedia.org/wiki/%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:%D0%9F%D0%BE%D0%B8%D1%81%D0%BA" compared to "http://ru.wikipedia.org/wiki/%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:Search"?

Comment 3

[Alexander L. Slovesnik]

Attachment: Patch v 1.1

Comment 4

[Milos Dinic [:Milos]]

Comment on attachment 720749 [details] [diff] [review]
Patch v 1.1

Review of attachment 720749 [details] [diff] [review]:
-----------------------------------------------------------------

r+. Please wait for Axel's positive feedback and then push upstream with appropriate commit message, ie. mentioning this bug and our reviews.

Comment 5

[Axel Hecht [:Pike]]

Is this the same patch as in bug 847460?

Comment 6

[Alexander L. Slovesnik]

(In reply to Axel Hecht [:Pike] from comment #5)
> Is this the same patch as in bug 847460?

This patch is for searchplugin in /mobile/, bug 847460 - for  searchplugin in /browser/

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 720749 [details] [diff] [review]
Patch v 1.1

Review of attachment 720749 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, thanks, then let's review this.

r=me with the same nit, I like that we're using the localized name for Special:Search, but it's hard to review as is, can we use the human readable Служебная:Поиск instead of %D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:%D0%9F%D0%BE%D0%B8%D1%81%D0%BA?

Comment 8

[Alexander L. Slovesnik]

Checked in central, aurora and beta:
http://hg.mozilla.org/l10n-central/ru/rev/e75a7adc3926
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ru/rev/841c45b39346
http://hg.mozilla.org/releases/l10n/mozilla-beta/ru/rev/44c0ba54e967