Closed Bug 846725 Opened 7 years ago Closed 6 years ago

[ru] Don't hardcode mobile site for wikipedia-ru for Fennec Russian

Categories

(Mozilla Localizations :: ru / Russian, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Assigned: unghost)

References

Details

(Keywords: productization)

Attachments

(1 file, 1 obsolete file)

In bug 825821, we stopped hard-coding the mobile site in the wikipedia plugin, so that wp can work it's magic on whether it should show you the mobile or the desktop site.

Mind porting that change over to your localization? Milos might be able to help. We'll want a patch for the change, and get Milos to review it, or he'll just write the patch himself.

I'm filing this independent of whether we're shipping Fennec, or are close doing so.
Attached patch Patch v 1.0 (obsolete) — Splinter Review
Assignee: nobody → unghost
Status: NEW → ASSIGNED
Attachment #719998 - Flags: review?(milos)
Attached patch Patch v 1.1Splinter Review
Attachment #719998 - Attachment is obsolete: true
Attachment #719998 - Flags: review?(milos)
Attachment #720749 - Flags: review?(milos)
Comment on attachment 720749 [details] [diff] [review]
Patch v 1.1

Review of attachment 720749 [details] [diff] [review]:
-----------------------------------------------------------------

r+. Please wait for Axel's positive feedback and then push upstream with appropriate commit message, ie. mentioning this bug and our reviews.
Attachment #720749 - Flags: review?(milos)
Attachment #720749 - Flags: review+
Attachment #720749 - Flags: feedback?(l10n)
Is this the same patch as in bug 847460?
(In reply to Axel Hecht [:Pike] from comment #5)
> Is this the same patch as in bug 847460?

This patch is for searchplugin in /mobile/, bug 847460 - for  searchplugin in /browser/
Comment on attachment 720749 [details] [diff] [review]
Patch v 1.1

Review of attachment 720749 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, thanks, then let's review this.

r=me with the same nit, I like that we're using the localized name for Special:Search, but it's hard to review as is, can we use the human readable Служебная:Поиск instead of %D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:%D0%9F%D0%BE%D0%B8%D1%81%D0%BA?
Attachment #720749 - Flags: feedback?(l10n) → feedback+
You need to log in before you can comment on or make changes to this bug.