Closed Bug 846726 Opened 7 years ago Closed 7 years ago

[sk] Don't hardcode mobile site for wikipedia-sk for Fennec Slovak

Categories

(Mozilla Localizations :: sk / Slovak, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Assigned: wladow)

References

Details

(Keywords: productization)

Attachments

(1 file, 2 obsolete files)

In bug 825821, we stopped hard-coding the mobile site in the wikipedia plugin, so that wp can work it's magic on whether it should show you the mobile or the desktop site.

Mind porting that change over to your localization? Milos might be able to help. We'll want a patch for the change, and get Milos to review it, or he'll just write the patch himself.

I'm filing this independent of whether we're shipping Fennec, or are close doing so.
Attached patch Porting en-us patch (obsolete) — Splinter Review
Attachment #720065 - Flags: review?(milos)
Comment on attachment 720065 [details] [diff] [review]
Porting en-us patch

Review of attachment 720065 [details] [diff] [review]:
-----------------------------------------------------------------

Vlado, can we please use "http://sk.wikipedia.org/wiki/%C5%A0peci%C3%A1lne:H%C4%BEadanie" instead?
Attached patch Porting en-us patch, v2 (obsolete) — Splinter Review
Attachment #720065 - Attachment is obsolete: true
Attachment #720065 - Flags: review?(milos)
Attachment #720804 - Flags: review?(milos)
Comment on attachment 720804 [details] [diff] [review]
Porting en-us patch, v2

Review of attachment 720804 [details] [diff] [review]:
-----------------------------------------------------------------

r+. Please wait for Axel's positive feedback and then push upstream with appropriate commit message, ie. mentioning this bug and our reviews.
Attachment #720804 - Flags: review?(milos)
Attachment #720804 - Flags: review+
Attachment #720804 - Flags: feedback?(l10n)
Blocks: 860063
Comment on attachment 720804 [details] [diff] [review]
Porting en-us patch, v2

Review of attachment 720804 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, please use the human-readable Špeciálne:Hľadanie instead of the encoded version. Please fix the SearchForm, too, that's only half localized.
Attachment #720804 - Flags: feedback?(l10n) → feedback-
fixes as per comment 5
Assignee: rozbora → wladow
Attachment #720804 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #739215 - Flags: review?(l10n)
Comment on attachment 739215 [details] [diff] [review]
Porting en-us patch, v3

Review of attachment 739215 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks.

Please land this with a checkin comment referencing this bug and my review.
Attachment #739215 - Flags: review?(l10n) → review+
You need to log in before you can comment on or make changes to this bug.