846728 - [zh-TW] Don't hardcode mobile site for wikipedia-zh-TW for Fennec Chinese (Traditional)

Status: RESOLVED FIXED

(Mozilla Localizations :: zh-TW / Chinese (Traditional), defect)

Description

[Axel Hecht [:Pike]]

In bug 825821, we stopped hard-coding the mobile site in the wikipedia plugin, so that wp can work it's magic on whether it should show you the mobile or the desktop site.

Mind porting that change over to your localization? Milos might be able to help. We'll want a patch for the change, and get Milos to review it, or he'll just write the patch himself.

I'm filing this independent of whether we're shipping Fennec, or are close doing so.

Comment 1

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Attachment: patch v1

Comment 2

[Milos Dinic [:Milos]]

Comment on attachment 720216 [details] [diff] [review]
patch v1

Review of attachment 720216 [details] [diff] [review]:
-----------------------------------------------------------------

Peter, can we please use "http://zh.wikipedia.org/wiki/Special:%E6%90%9C%E7%B4%A2"?

Comment 3

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Attachment: patch v2, use localized search url

Comment 4

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Milos, ping?

Comment 5

[Milos Dinic [:Milos]]

Comment on attachment 720602 [details] [diff] [review]
patch v2, use localized search url

Review of attachment 720602 [details] [diff] [review]:
-----------------------------------------------------------------

r+. Please wait for Axel's positive feedback and then push upstream with appropriate commit message, ie. mentioning this bug and our reviews.

Comment 6

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

so, Pike?

Comment 7

[Axel Hecht [:Pike]]

One request is good enough, I'll look once I have cycles.

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 720602 [details] [diff] [review]
patch v2, use localized search url

Review of attachment 720602 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with a nit, I like that we're using the localized version of Special:Search, but can we use the human readable version of Special:搜索 instead of the cumbersome Special:%E6%90%9C%E7%B4%A2 ?

Comment 9

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

(In reply to Axel Hecht [:Pike] from comment #8)
> r=me with a nit, I like that we're using the localized version of
> Special:Search, but can we use the human readable version of Special:搜索
> instead of the cumbersome Special:%E6%90%9C%E7%B4%A2 ?

I would trust escaped URL more than unescaped one, although it shouldn't be a problem. 

Patch landed:
aurora:　https://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/rev/8d9e5b51e4f1
central: https://hg.mozilla.org/l10n-central/zh-TW/rev/960352f362b3

Marking as RESOLVED FIXED.

Comment 10

[Axel Hecht [:Pike]]

Peter, seems like you landed the cumbersome url?

I'd also prefer the 

<SearchForm>http://zh.wikipedia.org/wiki/Special:Search</SearchForm>

to be the localized url, too.

Comment 11

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Okay, I'll resubmit the patch.

Should I request a new patch review or simply land the new patch?

Comment 12

[Axel Hecht [:Pike]]

Request another round of review? Thanks.

Comment 13

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Attachment: patch v3, use localized and escaped url

Comment 14

[Axel Hecht [:Pike]]

Comment on attachment 744664 [details] [diff] [review]
patch v3, use localized and escaped url

Review of attachment 744664 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, r=me. We'll not need another review from Milos, just land like usual with bug number and review notes in the comment.

Comment 15

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Thanks for reviewing, patches landed:

-aurora: https://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/rev/4a603c6b7c0e
-central: https://hg.mozilla.org/l10n-central/zh-TW/rev/7ecd8826bc81


Marking as RESOLVED FIXED again, let's wait for building... :)