846749 - fix up marionette-listener.js&marionette-actors.js style and comments

Status: RESOLVED WONTFIX

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

I seem to have overlooked something in your recent patches. We should replace all var assignments with let so we can prevent overwriting any global vars and enforce scoping.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

there are var/let out of the scope her just Yiming's patches, and are spread around marionette, a lot with other style inconsistencies and missing comments (we should comment on what each function takes in as params, and recently we've been neglecting to do so). So I'll change this just to a general cleanup bug for marionette code.

Comment 2

[Ryan]

Hello,

I would like to work on this bug. Just for clarification, what kind of style inconsistencies would need to be changed (aside from function param comments)?

Comment 3

[David Burns :automatedtester]

Hey Ryan,

If we start on with what has been asked for in comment 1 and comment 2 that would be great.

If you haven't followed the steps before on checking out the firefox source and working against it I would follow the details on MDN https://developer.mozilla.org/en-US/docs/Simple_Firefox_build

I can be found on irc://irc.mozilla.org in #ateam if you want to have a chat

Thanks!

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I'm not convinced it's a good idea to use `let` until SpiderMonkey has a spec-compliant implementation.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

:automatedtester- is this still a worthwhile bug to fix?  If so, and if this makes a good first bug, can you link to the code, how to reproduce this problem, and what an ideal fix looks like?

Comment 6

[David Burns :automatedtester]

since we are doing major refactor work this probably isnt needed anymore so closing

Comment 7

[Andreas Tolfsen ❲:ato❳]

The bug :automatedtester is referring to is bug 1107706.  I suspect a good linting is still needed afterwards, but we can deal with that when the need arises.