Closed Bug 846762 Opened 11 years ago Closed 11 years ago

Inconsistent close behaviour of private windows

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(seamonkey2.18 fixed, seamonkey2.19 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.19
Tracking Flags:
Tracking Status
seamonkey2.18 --- fixed
seamonkey2.19 --- fixed

People

(Reporter: neil, Assigned: neil)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Proposed patch
1.35 KB, patch
iannbugzilla
: review+
philip.chee
: review+
iannbugzilla
: approval-comm-aurora+
Details | Diff | Splinter Review 
Private Windows close without prompting if there are no normal browser windows open, but if there is a browser window open, then the private window prompts as if it was a browser window.

According to bug 844561, Private Windows should never prompt.
Attached patch Proposed patch — — Splinter Review 
I'm assuming that we still need to honour unbeforeunload.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #720123 - Flags: review?(philip.chee)
Attachment #720123 - Flags: review?(iann_bugzilla)
I mean onbeforeunload. I typed it right the first two times when Bugzilla errored out on me :-(
(In reply to neil@parkwaycc.co.uk from comment #2)
> I mean onbeforeunload. I typed it right the first two times when Bugzilla
> errored out on me :-(

I cannot see where we listener for "beforeunload" in the suite.
Attachment #720123 - Flags: review?(iann_bugzilla) → review+
(In reply to Ian Neal from comment #3)
> (In reply to comment #2)
> > I mean onbeforeunload. I typed it right the first two times when Bugzilla
> > errored out on me :-(
> 
> I cannot see where we listener for "beforeunload" in the suite.

We don't listen for it, pages do. We send it by means of the permitUnload call near the end of WindowIsClosing().
Pushed comm-central changeset 70b7a4895fb3.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 720123 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: Unexpected prompt to close private windows
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None
Attachment #720123 - Flags: approval-comm-aurora?
Attachment #720123 - Flags: approval-comm-aurora? → approval-comm-aurora+
Comment on attachment 720123 [details] [diff] [review]
Proposed patch

ex post facto r=me :P

> +  if (!gPrivate && !/Mac/.test(navigator.platform) && isClosingLastBrowser()) {
Too late to mention this but could have changed this to:
!navigator.platform.contains("Mac");
Attachment #720123 - Flags: review?(philip.chee) → review+
Target Milestone: --- → seamonkey2.19
You need to log in before you can comment on or make changes to this bug.