846765 - Dragging from Downloads window and dropping in Finder creates weird shortcut

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[David Tenser [:djst]]

Bug 462172 appears to be cross-platform, but I noticed today that it doesn't work on the Mac. This is tested on Firefox 19 running on OS X 10.8.2. 

When dropping a file from the Download window on Firefox onto e.g. the desktop, a strange shortcut is created instead of actually moving/copying the file there. This is different from how it works on Windows.

Comment 1

[Jesse Ruderman]

A weird shortcut indeed.  It's called "Users:.fileloc" in terminal or "Users/.fileloc" in finder, and it has an Opera icon.  But double-clicking it opens the PDF I downloaded in Preview.

Comment 3

[Marco Castelluccio [:marco]]

Is bug 544932 the problem?

Comment 4

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 784254 [details] [diff] [review]
Patch

Review of attachment 784254 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsClipboard.mm
@@ +483,5 @@
> +      if (!file) {
> +        nsCOMPtr<nsISupportsInterfacePointer> ptr(do_QueryInterface(genericFile));
> +        if (ptr) {
> +          ptr->GetData(getter_AddRefs(file));
> +        }

I'm kind of surprised this compiles.  GetData returns an nsISupports*, not an nsIFile*.  I would expect you to need to pass in an getter_AddRefs<nsISupports> here and QI to nsIFile afterwards.

Comment 6

[Marco Castelluccio [:marco]]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #5)
> I'm kind of surprised this compiles.  GetData returns an nsISupports*, not
> an nsIFile*.  I would expect you to need to pass in an
> getter_AddRefs<nsISupports> here and QI to nsIFile afterwards.

On Windows we're doing the same: http://mxr.mozilla.org/mozilla-central/source/widget/windows/nsDataObj.cpp#1357

Comment 7

[Marco Castelluccio [:marco]]

Attachment: Patch v2

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Marco Castelluccio [:marco] from comment #6)
> (In reply to Kyle Huey [:khuey] ([e-mail]) from comment #5)
> > I'm kind of surprised this compiles.  GetData returns an nsISupports*, not
> > an nsIFile*.  I would expect you to need to pass in an
> > getter_AddRefs<nsISupports> here and QI to nsIFile afterwards.
> 
> On Windows we're doing the same:
> http://mxr.mozilla.org/mozilla-central/source/widget/windows/nsDataObj.
> cpp#1357

Yeah turns out this is a bug in nsCOMPtr.  This shouldn't be allowed.

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 784461 [details] [diff] [review]
Patch v2

Review of attachment 784461 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0f70faea778

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d0f70faea778